[Fleet] Create shared package policy #185916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:feature
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
reviewed
Jun 11, 2024
...ctions/agent_policy/create_package_policy_page/components/steps/step_select_agent_policy.tsx
Outdated
Show resolved
Hide resolved
…policy/create_package_policy_page/components/steps/step_select_agent_policy.tsx Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
nchaulet
reviewed
Jun 11, 2024
..._policy/create_package_policy_page/components/steps/components/agent_policy_multi_select.tsx
Outdated
Show resolved
Hide resolved
nchaulet
approved these changes
Jun 11, 2024
nchaulet
reviewed
Jun 11, 2024
| }, [agentPolicyMultiOptions, selectedPolicyIds]); | ||
|
|
||
| const [selected, setSelected] = React.useState<any>(selectedOptions); |
There was a problem hiding this comment.
Do we need that state cannot we use selectedOptions directly? changing selectedPolicyIds should update it no?
There was a problem hiding this comment.
You are right, it's not necessary, updated.
💛 Build succeeded, but was flaky
Failed CI StepsThe CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
2 tasks
criamico
added a commit
that referenced
this pull request
Jun 14, 2024
Closes #182111 ## Summary Show multiple agent policies in integrations table. ## Testing - Enable feature flag `enableReusableIntegrationPolicies` - Install an integration that has more than one agent policies associated with it (instructions are [here](#185916)) - Navigate to integrations table and verify that the policy displays a badge with the number of associated policies -1 and that it opens up a popover, like in below screenshots. **NOTE** the button "Manage agent policies" does not work for now, as the feature is under development and it's hidden with a feature flag! ### With feature flag enabled, when integration has multiple agent policies   When one of the policies is managed:  ### When feature flag not enabled or integration has only one agent policy The UI remains as it is today:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/ingest-dev/issues/3263
Added multi-select agent policy component to Add integration policy page.
Steps to verify
To verify:
xpack.fleet.enableExperimental: ['enableReusableIntegrationPolicies']tokibana.dev.ymllocallyPreview API Requestbutton)Logstash output restriction
There are a few scenarios where agent policy selection is restricted.
EuiComboBoxcomponent doesn't support a multiline custom option rendering, so added a warning icon with a tooltip instead.Existing UI with
EuiSuperSelect:Limited packages restriction
The other restrictions don't allow limited packages to be added twice to an agent policy: endpoint, osquery.
Test by adding osquery_manager to one agent policy, and then try to add another integration policy to the same agent policy. It should be disabled.
Agent policies used by agents
The UI shows the sum of agents enrolled to the selected agent policies
The
Preview API Requestfeature should keep thepolicy_idslist in sync when adding/removing agent policies.The confirmation modal should also show a sum of enrolled agents and list of selected agent policies.
Checklist