Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution][Endpoint] Re-enable several skipped tests #186073

Merged
merged 6 commits into from
Jun 12, 2024
Merged

[SecuritySolution][Endpoint] Re-enable several skipped tests #186073

merged 6 commits into from
Jun 12, 2024

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jun 12, 2024 •
edited
Loading

Summary

Re-enables skipped tests that were failing and were skipped because of an Endpoint bug.

closes /issues/168427
closes /issues/168340
closes /issues/168719
closes /issues/168284
closes /issues/171444
closes /issues/170373
closes /issues/173464
closes /issues/173465

Checklist

Delete any items that are not applicable to this PR.

@ashokaditya ashokaditya self-assigned this Jun 12, 2024
@ashokaditya ashokaditya added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.15.0 labels Jun 12, 2024
@ashokaditya ashokaditya marked this pull request as ready for review June 12, 2024 10:04
@ashokaditya ashokaditya requested a review from a team as a code owner June 12, 2024 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@ashokaditya ashokaditya added the release_note:skip Skip the PR/issue when compiling release notes label Jun 12, 2024
tomsonpl
tomsonpl approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thx!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / X-Pack Accessibility Tests - Group 3 Security Solution Accessibility Detections Create Rule Flow Custom Query Rule Define Step preview section meets a11y requirements

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 6a2e5a4 into elastic:main Jun 12, 2024
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 12, 2024
@ashokaditya ashokaditya deleted the task/dw-reenable-several-skipped-tests branch June 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@pzl pzl pzl approved these changes

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

@ashokaditya ashokaditya

Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute·cy·ts - Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/automated_response_actions/automated_response_actions·cy·ts - Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint_list/endpoints·cy·ts - Endpoints page "after all" hook for "Shows endpoint on the list" "after all" hook for "Shows endpoint on the list" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/automated_response_actions/automated_response_actions·cy·ts - Automated Response Actions From alerts "after all" hook for "should have generated endpoint and rule" "after all" hook for "should have generated endpoint and rule" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/endpoint_list/endpoints·cy·ts - Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute·cy·ts - Response console Execute operations: "after all" hook for ""execute --command" - should execute a command" "after all" hook for ""execute --command" - should execute a command" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/isolate·cy·ts - Response console Host Isolation: "before all" hook for "should isolate a host from response console" "before all" hook for "should isolate a host from response console" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/isolate·cy·ts - Response console Host Isolation: "after all" hook for "should isolate a host from response console" "after all" hook for "should isolate a host from response console"
6 participants
@ashokaditya @elasticmachine @kibana-ci @pzl @tomsonpl @kibanamachine