Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warning on xpack.fleet.enableExperimental #188917

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update warning on xpack.fleet.enableExperimental #188917

merged 1 commit into from
Jul 23, 2024

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Jul 23, 2024 •
edited by kibanamachine
Loading

Summary

Add warning on xpack.fleet.enableExperimental settings.

For maintainers

  • Review the wording.
  • Backport to all versions

@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kpollich kpollich requested a review from kilfoyle July 23, 2024 12:00
@kpollich
Copy link
Member

@kilfoyle - Could you take a quick look at the wording here just to confirm this is good to merge?

kilfoyle
kilfoyle approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Very nice wording on this!

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Jul 23, 2024
@kpollich kpollich merged commit 647b222 into main Jul 23, 2024
14 checks passed
@kpollich kpollich deleted the warn-experimental-fleet branch July 23, 2024 16:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 23, 2024
@lucabelluccini
Update warning on xpack.fleet.enableExperimental (elastic#188917)
7c6ea8f 
## Summary

Add warning on `xpack.fleet.enableExperimental` settings.

### For maintainers

- [x] Review the wording.
- [ ] Backport to all versions

(cherry picked from commit 647b222)
@kibanamachine kibanamachine mentioned this pull request Jul 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 188917

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 23, 2024
@kibanamachine @lucabelluccini
[8.15] Update warning on `xpack.fleet.enableExperimental` (#…
255cde9 
…188917) (#188983)

# Backport

This will backport the following commits from `main` to `8.15`:
- [Update warning on `xpack.fleet.enableExperimental`
(#188917)](#188917)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Luca
Belluccini","email":"luca.belluccini@elastic.co"},"sourceCommit":{"committedDate":"2024-07-23T16:25:34Z","message":"Update
warning on `xpack.fleet.enableExperimental` (#188917)\n\n##
Summary\r\n\r\nAdd warning on `xpack.fleet.enableExperimental`
settings.\r\n\r\n### For maintainers\r\n\r\n- [x] Review the
wording.\r\n- [ ] Backport to all
versions","sha":"647b22266eea9858f682894393ab8d64fe7f6160","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.16.0"],"title":"Update
warning on
`xpack.fleet.enableExperimental`","number":188917,"url":"https://github.com/elastic/kibana/pull/188917","mergeCommit":{"message":"Update
warning on `xpack.fleet.enableExperimental` (#188917)\n\n##
Summary\r\n\r\nAdd warning on `xpack.fleet.enableExperimental`
settings.\r\n\r\n### For maintainers\r\n\r\n- [x] Review the
wording.\r\n- [ ] Backport to all
versions","sha":"647b22266eea9858f682894393ab8d64fe7f6160"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188917","number":188917,"mergeCommit":{"message":"Update
warning on `xpack.fleet.enableExperimental` (#188917)\n\n##
Summary\r\n\r\nAdd warning on `xpack.fleet.enableExperimental`
settings.\r\n\r\n### For maintainers\r\n\r\n- [x] Review the
wording.\r\n- [ ] Backport to all
versions","sha":"647b22266eea9858f682894393ab8d64fe7f6160"}}]}]
BACKPORT-->

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/express-4.19.2
df656a6 
* master: (3487 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
TinLe added a commit to TinLe/kibana that referenced this pull request Jul 30, 2024
@TinLe
Merge branch 'master' into dependabot/npm_and_yarn/pdfjs-dist-4.2.67
8bec40b 
* master: (2400 commits)
  `BedrockChat` & `GeminiChat` (elastic#186809)
  [ResponseOps] log error when ES Query rules find docs out of time range (elastic#186332)
  skip flaky suite (elastic#188997)
  [Security solution][Alert Details] Enable preview feature flag and cypress tests (elastic#188580)
  [EuiProviders] Warn Developer if EuiProvider is missing (elastic#184608)
  [Security Solution ] Fixes Timeline infinite loading bug (elastic#188943)
  Improve SearchSource SearchRequest type (elastic#186862)
  Deprecate Search Sessions config (elastic#188037)
  [Synthetics] Add missing monitorType and tag info in cards !! (elastic#188824)
  [Console Monaco] Resolve uncaught error from tokenizer (elastic#188746)
  [Data Forge] Add `service.logs` dataset as a  data stream (elastic#188786)
  [Console] Fix failing bulk requests (elastic#188552)
  Update dependency terser to ^5.31.2 (main) (elastic#188528)
  [APM][ECO] Telemetry (elastic#188627)
  [Fleet] Fix uninstall package validation accross space (elastic#188749)
  Update warning on `xpack.fleet.enableExperimental` (elastic#188917)
  [DOCS][Cases] Automate more screenshots for cases (elastic#188697)
  [Fleet] Fix get one agent when feature flag disabled (elastic#188953)
  chore(investigate): Add investigate-app plugin from poc (elastic#188122)
  [Monaco Editor] Add Search functionality (elastic#188337)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@kpollich kpollich kpollich approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucabelluccini @kpollich @kibanamachine @kilfoyle