Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timeline] Events request end tracking #191289

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Aug 26, 2024

Summary

Bring APM endTracking calls back in the timeline events request, since they were accidentally removed here

@semd semd added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Aug 26, 2024
@semd semd self-assigned this Aug 26, 2024
@semd semd requested a review from a team as a code owner August 26, 2024 15:17
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@semd semd enabled auto-merge (squash) August 26, 2024 17:02
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.0MB 18.0MB +59.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit a1e216b into elastic:main Aug 26, 2024
52 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2024
## Summary

Bring APM `endTracking` calls back in the timeline events request, since
they were accidentally removed
[here](elastic@f1dc15a#diff-982a0a7f37bfa4c40cc92dc21648118bb152723ad895d932da368341ddea1628L263)

(cherry picked from commit a1e216b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 26, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Timeline] Events request end tracking
(#191289)](#191289)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-08-26T17:23:54Z","message":"[Timeline]
Events request end tracking (#191289)\n\n## Summary\r\n\r\nBring APM
`endTracking` calls back in the timeline events request, since\r\nthey
were accidentally
removed\r\n[here](https://github.com/elastic/kibana/commit/f1dc15ae4b99791616295e4c6832ee8a10d9eab6#diff-982a0a7f37bfa4c40cc92dc21648118bb152723ad895d932da368341ddea1628L263)","sha":"a1e216b148a7821c0b7cee8b336939dfd75a4dfb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.16.0"],"title":"[Timeline]
Events request end
tracking","number":191289,"url":"https://github.com/elastic/kibana/pull/191289","mergeCommit":{"message":"[Timeline]
Events request end tracking (#191289)\n\n## Summary\r\n\r\nBring APM
`endTracking` calls back in the timeline events request, since\r\nthey
were accidentally
removed\r\n[here](https://github.com/elastic/kibana/commit/f1dc15ae4b99791616295e4c6832ee8a10d9eab6#diff-982a0a7f37bfa4c40cc92dc21648118bb152723ad895d932da368341ddea1628L263)","sha":"a1e216b148a7821c0b7cee8b336939dfd75a4dfb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191289","number":191289,"mergeCommit":{"message":"[Timeline]
Events request end tracking (#191289)\n\n## Summary\r\n\r\nBring APM
`endTracking` calls back in the timeline events request, since\r\nthey
were accidentally
removed\r\n[here](https://github.com/elastic/kibana/commit/f1dc15ae4b99791616295e4c6832ee8a10d9eab6#diff-982a0a7f37bfa4c40cc92dc21648118bb152723ad895d932da368341ddea1628L263)","sha":"a1e216b148a7821c0b7cee8b336939dfd75a4dfb"}}]}]
BACKPORT-->

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants