[8.x] [Logs] Remove AI Assistant specific log index setting (#192003) #193723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Closes elastic/logs-dev#167. - Removes registration of the AI Assistant specific advanced setting (`observability:aiAssistantLogsIndexPattern`). - Replaces the setting with use of the central log sources setting (`observability:logSources`). - ℹ️ Also registers the central log sources setting in serverless (this was missed previously). Due to the impact that this setting has on alerts ([Discussion](elastic/logs-dev#170 (comment))) a migration path from one setting to the other isn't really possible, as values from the AI Assistant setting could potentially cause unwanted alerts. As such these changes opt for the route that we'll do a straight swap, and document this in release notes. We will also need to do a migration on the `config` (for advanced settings) Saved Object to remove instances of the old setting / property. With the new "model version" migration model [my understanding is this should happen in a separate followup PR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).⚠️ ~One potentially open question is whether the custom management section that the AI Assistant mounts when clicking "AI Assistant Settings" should render the log sources setting? (As this setting affects more than just the AI Assistant).~ [Resolved](elastic#192003 (comment))  --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit ebe4686) # Conflicts: # packages/serverless/settings/observability_project/index.ts
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
neptunian
approved these changes
Sep 24, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
neptunian
pushed a commit
to neptunian/kibana
that referenced
this pull request
Oct 1, 2024
…192003) (elastic#193723) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Remove AI Assistant specific log index setting (elastic#192003)](elastic#192003) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2024-09-17T13:26:54Z","message":"[Logs] Remove AI Assistant specific log index setting (elastic#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","backport:skip","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","apm:review"],"number":192003,"url":"https://github.com/elastic/kibana/pull/192003","mergeCommit":{"message":"[Logs] Remove AI Assistant specific log index setting (elastic#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192003","number":192003,"mergeCommit":{"message":"[Logs] Remove AI Assistant specific log index setting (elastic#192003)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/logs-dev/issues/167.\r\n\r\n- Removes registration of the AI Assistant specific advanced setting\r\n(`observability:aiAssistantLogsIndexPattern`).\r\n- Replaces the setting with use of the central log sources setting\r\n(`observability:logSources`).\r\n- ℹ️ Also registers the central log sources setting in serverless (this\r\nwas missed previously).\r\n\r\nDue to the impact that this setting has on alerts\r\n([Discussion](https://github.com/elastic/logs-dev/issues/170#issuecomment-2229130314))\r\na migration path from one setting to the other isn't really possible, as\r\nvalues from the AI Assistant setting could potentially cause unwanted\r\nalerts. As such these changes opt for the route that we'll do a straight\r\nswap, and document this in release notes.\r\n\r\nWe will also need to do a migration on the `config` (for advanced\r\nsettings) Saved Object to remove instances of the old setting /\r\nproperty. With the new \"model version\" migration model [my understanding\r\nis this should happen in a separate followup\r\nPR](https://github.com/elastic/kibana/blob/main/packages/core/saved-objects/core-saved-objects-server/src/model_version/model_change.ts#L131).\r\n\r\n⚠️ ~One potentially open question is whether the custom management\r\nsection that the AI Assistant mounts when clicking \"AI Assistant\r\nSettings\" should render the log sources setting? (As this setting\r\naffects more than just the AI Assistant).~\r\n[Resolved](https://github.com/elastic/kibana/pull/192003#issuecomment-2352727034)\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"ebe4686e6c53a640d8ff2cfc60a7eeceb132812b"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation