Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] removes unsupported adv settings options for Serverless #194108

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[Security Solution][Detection Engine] removes unsupported adv settings options for Serverless #194108

merged 4 commits into from
Oct 9, 2024

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Sep 26, 2024 •
edited by kibanamachine
Loading

Summary

@vitaliidm vitaliidm self-assigned this Sep 26, 2024
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Detection Engine Security Solution Detection Engine Area 8.16 candidate v8.16.0 labels Sep 26, 2024
@vitaliidm vitaliidm requested review from a team and nkhristinin September 26, 2024 09:39
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 140 139 -1
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 142 140 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm marked this pull request as ready for review September 26, 2024 11:07
@vitaliidm vitaliidm requested review from a team as code owners September 26, 2024 11:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero yctercero requested a review from a team September 30, 2024 14:14
@PhilippeOberti PhilippeOberti removed the request for review from a team October 7, 2024 14:35
@vitaliidm vitaliidm enabled auto-merge (squash) October 9, 2024 09:10
@vitaliidm vitaliidm merged commit f72ab5e into elastic:main Oct 9, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11257213343

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 142 141 -1
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 144 142 -2

History

cc @vitaliidm

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@vitaliidm
[Security Solution][Detection Engine] removes unsupported adv setting…
0161821 
…s options for Serverless (elastic#194108)

## Summary

 - addresses elastic#188051
 - removes adv settings options:
   - CCS rule privileges warning
   - Exclude cold and frozen tiers in Analyzer

(cherry picked from commit f72ab5e)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @vitaliidm
[8.x] [Security Solution][Detection Engine] removes unsupported adv s…
ab8f467 
…ettings options for Serverless (#194108) (#195620)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Detection Engine] removes unsupported adv
settings options for Serverless
(#194108)](#194108)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T14:34:32Z","message":"[Security
Solution][Detection Engine] removes unsupported adv settings options for
Serverless (#194108)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/188051\r\n - removes adv
settings options:\r\n - CCS rule privileges warning\r\n - Exclude cold
and frozen tiers in
Analyzer","sha":"f72ab5ef7e072636c87acdbb86da080bcb158a27","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Detection Engine","8.16
candidate","v8.16.0"],"title":"[Security Solution][Detection Engine]
removes unsupported adv settings options for
Serverless","number":194108,"url":"https://github.com/elastic/kibana/pull/194108","mergeCommit":{"message":"[Security
Solution][Detection Engine] removes unsupported adv settings options for
Serverless (#194108)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/188051\r\n - removes adv
settings options:\r\n - CCS rule privileges warning\r\n - Exclude cold
and frozen tiers in
Analyzer","sha":"f72ab5ef7e072636c87acdbb86da080bcb158a27"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194108","number":194108,"mergeCommit":{"message":"[Security
Solution][Detection Engine] removes unsupported adv settings options for
Serverless (#194108)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/188051\r\n - removes adv
settings options:\r\n - CCS rule privileges warning\r\n - Exclude cold
and frozen tiers in
Analyzer","sha":"f72ab5ef7e072636c87acdbb86da080bcb158a27"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
@vitaliidm vitaliidm mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@sebelga sebelga sebelga approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees

@vitaliidm vitaliidm

Labels
8.16 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vitaliidm @kibana-ci @elasticmachine @kibanamachine @sabarasaba @sebelga @nkhristinin