Change the scale factor when upgrading panels with margins

[trevan]

Fixes #20635

This reduces the scale factor to 4 when migrating panels that are in a dashboard with margins.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[nreese]

lgtm
code review, tested in chrome by creating a dashboard with margins. Simulated 6.2.0 dashboards by modifying saved object panelsJSON for each panel by setting version to 6.2.0 and dividing x and w attributes by 4 and dividing y and h attributes by 5. I then loaded the dashboard objects to view their appearance.

[nreese]

A couple of screen shots from reviewing.

Loading a 6.2.0 dashboard with this PR (scaling factor of 4)

Loading a 6.2.0 dashboard on master (scaling factor of 5)

[stacey-gammon]

Nice reviewing @nreese . I did something similar but created dashboard in 6.2, then exported and imported in 6.3, once without this PR, then once with.

6.2:

6.3 with this PR (ignore the not found errors, didn't bother with data):

6.3 on master

Def a lot closer with this PR.

Code lgtm too.

[stacey-gammon]

retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[nreese]

Looks like a legitimate test failure in dashboard_grid_container.test.js

loads old panel data in the right order
20:40:38 
20:40:38     expect(received).toBe(expected) // Object.is equality
20:40:38     
20:40:38     Expected value to be:
20:40:38       35
20:40:38     Received:
20:40:38       28
20:40:38 
20:40:38       102 |   expect(foo8Panel.row).toBe(undefined);
20:40:38       103 |   expect(foo8Panel.gridData.y).toBe(35);
20:40:38     > 104 |   expect(foo8Panel.gridData.x).toBe(0);
20:40:38       105 | 
20:40:38       106 |   grid.unmount();
20:40:38       107 | });

[trevan]

That test was using useMargins = true because it is the default value in the store. I added a second test to check when useMargins = false and fixed the expected value.

[stacey-gammon]

retest

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[nreese]

6.x #20726
6.3 #20727