Fix flickering of visualizations on refresh #20817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
bug
💚 Build Succeeded |
markov00
reviewed
Jul 16, 2018
There was a problem hiding this comment.
I've tested it and works correctly on OSX Chrome, Firefox and Safari using the Global Flight Dashboard example dashboard.
I've see that the behaviour is correct for all the charts but the vega one where I can see a refresh of the tiles of the map. Seems to be present also into master, but I didn't tested in 6.3.
stacey-gammon
approved these changes
Jul 16, 2018
|
@markov00 I think the Vega map would be a separate issue, and I would like to fix this also separately, since I would like to backport this to 6.3 too ideally, but no need for an experimental visualization. |
markov00
approved these changes
Jul 16, 2018
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jul 16, 2018
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jul 16, 2018
timroes
added a commit
that referenced
this pull request
Jul 17, 2018
timroes
added a commit
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #20240 where vislib visualizations with a legend are flickering on dashboard in case of auto refresh.
The waiting for one render cycle was earlier in
visualizewhere it was used to make sure we first render the legend before we get the width/height of the remaining container, that we pass then to the vislib implementation. If we didn't do it, the chart assumed a wrong size and "overdraw" (or underdraw) the legend.Since the legend is now moved into the vislib vis type itself, we don't need to wait for it anymore, since the size calculation (that is passed to that class) isn't only for the chart area anymore, but for chart + legend beside each other, and drawing them beside each other works by the CSS styling of those two
divs.Testing hint: Since currently auto refreshing visualizations isn't working on
master, you can also just switch through the time ranges (using the arrows left and right of the time picker). Without that fix you should also experience the flickering, with that fix it should be gone.Testing: This should ideally not change anything beside getting rid of the flickering on auto-refresh or switching time ranges. Please make sure you test a couple of vislib charts with legends in different scenarios and also test expanding/collapsing of the legend. Everything should still work as expected.