Spaces Phase 1 #21408

…mption

Functional space management UI

* Introducing URL Context Merging to `spaces-phase-1`, and open TODO items in this PR will be addressed in separate PRs.

* Beginning to use the ES APIs to insert/check privileges * Removing todo comment, I think we're good with the current check * Adding ability to edit kibana application privileges * Introducing DEFAULT_RESOURCE constant * Removing unused arguments when performing saved objects auth check * Performing bulkCreate auth more efficiently * Throwing error in SavedObjectClient.find if type isn't provided * Fixing Reporting and removing errant console.log * Introducing a separate hasPrivileges "service" * Adding tests and fleshing out the has privileges "service" * Fixing error message * You can now edit whatever roles you want * We're gonna throw the find error in another PR * Changing conflicting version detection to work when user has no application privileges * Throwing correct error when user is forbidden * Removing unused interceptor * Adding warning if they're editing a role with application privileges we can't edit * Fixing filter... * Beginning to only update privileges when they need to be * More tests * One more test... * Restricting the rbac application name that can be chosen * Removing DEFAULT_RESOURCE check * Supporting 1024 characters for the role name * Renaming some variables, fixing issue with role w/ no kibana privileges * Throwing decorated general error when appropriate * Fixing test description * Dedent does nothing... * Renaming some functions

Adds Space Avatar with selector in main Kibana menu

When Kibana starts, a Default Space will be created if one does not already exist. The Default Space will contain all objects that are not currently assigned to any other space (i.e., objects created prior to Spaces being enabled, or objects created directly within the Default Space). To enable this, this PR also introduces the concept of Reserved Spaces, which is denoted by a `_reserved` property on the `space` object. Reserved Spaces: 1. Cannot be deleted 2. Cannot have their URL Context Changed This PR does not address: 1. Disabling the UI for reserved roles - this will be enabled via #19035 once this PR is merged into it.

…19511)

* Manually porting over the AuditLogger for use within the security audit logger * HasPrivileges now returns the user from the request * Has privileges returns username from privilegeCheck * Adding first eventType to the security audit logger * Adding authorization success message * Logging arguments when authorization success * Fixing test description * Logging args during audit failures

* Porting over the saved objects tests, a bunch are failing, I believe because security is preventing the requests * Running saved objects tests with rbac and xsrf disabled * Adding users * BulkGet now tests under 3 users * Adding create tests * Adding delete tests * Adding find tests * Adding get tests * Adding bulkGet forbidden tests * Adding not a kibana user tests * Update tests * Renaming the actions/privileges to be closer to the functions on the saved object client itself * Cleaning up tests and removing without index tests I'm considering the without index tests to be out of scope for the RBAC API testing, and we already have unit coverage for these and integration coverage via the OSS Saved Objects API tests. * Fixing misspelling

* Adding ability to specify filters when calling the repository * Implementing find filtering * Revert "Adding ability to specify filters when calling the repository" This reverts commit 9da30a1. * Adding integration tests for find filtering * Adding forbidden auth logging * Adding asserts to make sure some audit log isn't used * Adding more audit log specific tests * Necessarly is not a work, unfortunately * Fixing test * More descriptive name than "result" * Better unauthorized find message? * Adding getTypes tests

Redesigned Role Management screen using React and EUI

defaults

…nges (#19839) * Adding start to supporting basic license and switching to plat/gold * Initialize application privilages on XPack license change * restore mirror_status_and_initialize * additional tests and peer review updates * Introducing watchStatusAndLicenseToInitialize * Adding some tests * One more test * Even better tests * Removing unused mirrorStatusAndInitialize * Throwing an error if the wrong status function is called

* Basic implementation, rather sloppy * Cleaning stuff up a bit * Beginning to write tests, going to refactor how we build the privileges * Making the buildPrivilegesMap no longer return application name as the main key * Using real privileges since we need to use them for the legacy fallback * Adding more tests * Fixing spelling * Fixing test description * Fixing comment description * Adding similar line breaks in the has privilege calls * No more settings * No more rbac enabled setting, we just do RBAC * Using describe to cleanup the test cases * Logging deprecations when using the legacy fallback * Cleaning up a bit... * Using the privilegeMap for the legacy fallback tests * Now with even less duplication * Removing stray `rbacEnabled` from angularjs

@kobelb

@kobelb this seems unrelated to our RBAC Phase 1 work, but I was able to consistently reproduce this on my machine.

@kobelb

Here's a fix for the latest flaky test @kobelb

…#19915) causing issues that were really hard to replicate

No more hard-coded types! This will make it so that plugins that register their own mappings just transparently work.

This updates RBAC Phase 1 to work against the latest master. Specifically: 1. Removes `xpack_main`'s `registerLicenseChangeCallback`, which we introduced in `security-app-privs`, in favor of `onLicenseInfoChange`, which was recently added to master 2. Updated `x-pack/plugins/security/server/lib/watch_status_and_license_to_initialize.js` to be compliant with rxjs v6

* Retrying initialize 20 times with a scaling backoff * Logging error when we are registering the privileges

* Beginning to use alternate callWithRequest fallback * Only use legacy fallback when user has "some" privileges on index * Logging useLegacyFallback when there's an authorization failure * Adding tests, logging failure during find no types fallback * Switching to using an enum instead of success/useLegacyFallback * Using _execute to share some of the structure * Moving comment to where it belongs * No longer audit logging when we use the legacy fallback

initializing

* Logging legacy fallback deprecation on login * Consolidation the privileges/authorization folder * Exposing rudimentary authorization service and fixing authenticate tests * Moving authorization services configuration to initAuthorization * Adding "actions" service exposed by the authorization * Fixing misspelling * Removing invalid and unused exports * Adding note about only adding privileges * Calling it initAuthorizationService * Throwing explicit validation error in actions.getSavedObjectAction * Deep freezing authorization service * Adding deepFreeze tests * Checking privileges in one call and cleaning up tests

* Specifying the application on the "authorization service" * Moving watchStatusAndLicenseToInitialize to be below initAuthorizationService * Using short-hand propery assignment

* validate elasticsearch has_privileges response before trusting it * address feedback

* Beginning to work on external role management APIs * Refactoring GET tests and adding more permutations * Adding test for excluding other resources * Adding get role tests * Splitting out the endpoints, or else it's gonna get overwhelming * Splitting out the post and delete actions * Beginning to work on POST and the tests * Posting the updated role * Adding update tests * Modifying the UI to use the new public APIs * Removing internal roles API * Moving the rbac api integration setup tests to use the public role apis * Testing field_security and query * Adding create role tests * We can't update the transient_metadata... * Removing debugger * Update and delete tests * Returning a 204 when POSTing a Role. * Switching POST to PUT and roles to role * We don't need the rbacApplication client-side anymore * Adding delete route tests * Using not found instead of not acceptable, as that's more likely * Only allowing us to PUT known Kibana privileges * Removing transient_metadata * Removing one letter variable names * Using PUT instead of POST when saving roles * Fixing broken tests

)

This PR updates the new Role Management screen to use the public role API introduced as part of #20732. Additionally, this updates the breadcrumb nav for Spaces and Role management screens to be consistent with the nav introduced in #20739. There are a couple of visual glitches in this PR which are a result of current defects on master, so they can be safely ignored for the time being.

**This is an updated description that incorperates some of the discussions below** This PR introduces changes which allow the Spaces plugin to make saved objects "space aware". Effectively, this means wrapping the Saved Objects Client to alter or filter requests/responses. **Note** Advanced UI Settings (i.e., saved objects of type `config`) are not in scope for this PR, and will be addressed separately. ### Terminology: - SOC: Saved Objects Client ## Saved Objects Client ### `get` The response from the base SOC is checked to see if the object belongs to the current space. If not, a 404 is thrown to indicate the object does not exist. ### `bulk_get` The response from the base SOC is checked to see if each object belongs to the current space. For each object that does not belong, its contents are replaced with a 404 response, which looks identical to the base SOC's 404 response for a missing object. ### `create` The `spaceId` is appended to the create request, so the base SOC will write the new object into the correct space. ### `bulk_create` The `spaceId` is appended to each space-aware object in the request, so the base SOC will write the new objects into the correct space. ### `update` Before allowing an update to be processed by the base SOC, we check to ensure that it belongs to the current space. If not, a 404 is thrown. We also ensure that the `spaceId` is not changed as a result of an update. ### `delete` Before allowing a delete to be processed by the base SOC, we check to ensure that it belongs to the current space. If not, a 404 is thrown. ### `find` Searching is arguably the most complex case for this PR, and is responsible for a bulk of the LOC (other than tests). When performing a find, we augment the ES query to ensure that each object belongs to the current space. ## * Belonging to the current space To figure out if an object belongs to the current space, the following check is performed: ### 1. Is the object's type space-aware? Most saved object types are space-aware. There are a couple of exceptions as of this PR: space and config. If the type is not space-aware, then ✅ this object belongs to the current space. This implies that objects that are not space aware belong to every space. If the type is space-aware, then processing continues to step 2 ### 2. Check the object's `spaceId` Each saved object may have a `spaceId` assigned. This `spaceId` is compared against the `spaceId` that the user's request is executed within. If they match, then the object belongs to the current space. **caveat** The Default Space is a special-case space that does not assign a `spaceId` to its underlying objects. This is done to maintain backwards compatibility, and makes bootstrapping Spaces much easier for upgrading installations. Given this, there is logic in place which accounts for this special-case. The most interesting example is when we build the query for the SOC's `find` operation. Rather than checking that the object has a particular `spaceId`, we have to check that the object does not have a `spaceId` assigned.

From the end-user perspective, this is a simple rebranding of the URL Context. Internally, the space identifier is now used to represent both the url path of the space, as well as that space's document id in the kibana index. This provides the following benefits: 1) Eliminates the need to query ES to determine the active space id. 2) Prevents two spaces from sharing the same url path, which we had to manually check for in the past 3) Simplifies using the role management API As an added bonus, the Space Description is now optional 🎉

Saved Objects that are space-aware will have their space id appended to their document id. This is similar to how each object's type is part of their document id. Objects that are not space-aware do not have their space id appended. Objects that exist in the default space do not have their space id appended. This maintains backward compatibility. ### Motivation Appending the space id greatly simplifies space-aware advanced settings, and it also simplifies importing/exporting objects between different spaces (by avoiding id conflicts). ### Tradeoffs Once objects exist in a user-created space (i.e., not the default space), then the Spaces plugin should not be removed or disabled from the Kibana installation.

This moves the spaces management link into the Kibana section, rather than a dedicated Spaces section

@kobelb

@kobelb -- this PR in its current state is just enough to get the reporting API tests passing again. This doesn't account for space-awareness, and I'll need to pick your brain as to how to do that for reporting, but I figured that would be better addressed when we tackle space-aware advanced settings (it appears that reporting is only using the SOC via the UISettingsService below)

…s-phase-1

…19497) This replaces the existing Modal with a smaller Popover which is less intrusive. The popover also features a search bar for finding the desired Space when there are 8 or more Spaces to choose from. ### Details When there are less than 8 spaces available, the selector will render a simple list of spaces. When there are >= 8 spaces available, the selector will also render a search bar to let users search for their space. ### Prerequisites - [x] Merge #18862 into `spaces-phase-1` ### Known Issues - elastic/eui#1043 (fixed in `v3.2.0`) - elastic/eui#1052 (fixed in `v3.2.1`) - Missing typdefs (not a blocker to merge): elastic/eui#1120

* Moving global privileges to it's new designated location * Adjusting get to be new structure * Updating PUT * Updating UI to work with the new API

This PR includes enhancements to the Role Management screen to allow users to specify Kibana Privileges on a per-space level. This PR does not include changes to *enforce* space-aware privileges; this only includes the UI/API changes necessary to support editing a role's privileges.

[skip ci] This PR makes the "Recently viewed" widget on the Kibana home page space-aware. The widget will only show saved objects that were viewed within the user's current space. This is accomplished by changing the way the `RecentlyAccessed` module creates its `PersistedLog`. Previously, the `PersistedLog` was using a hard-coded key, but now it is deriving its key based off of the current `basePath`, which contains the space identifier. I chose this approach because this code lies completely within OSS Kibana, and I did not want to make this module aware of the Spaces plugin. Spaces augments the `basePath` in order to function and construct space-aware links within the UI, so this ends up being transparent to consumers of `chrome.getBasePath` You'll notice that the `PersistedLog` key is partially hashed. We do this because we don't want the browser to store information about which spaces a particular user may or may not have access to (see this [earlier conversation](#19417 (comment))) ### Important Installations that have a configured `basePath` other than the default `''` will have their "Recently viewed" list cleared after upgrading to 6.5, because the basePath will become part of the `localStorage` key, when it previously wasn't. While this may _technically_ be a breaking change, I'm hoping this will be acceptable. Fixes #21961

Introduces basic telemetry for Spaces. Implementation inspired by Reporting's telemetry collector. Reports the following: `available`: Indicates of the current license allows for Spaces `enabled`: Indicates if Spaces is enabled (also implies it is available) `count`: The number of Spaces this installation has configured Fixes #19260

…s-phase-1

* Adding a namespace * Allowing the saved objects client wrappers to specify the namespace * Moving namespace agnosticism to OSS * Fixing rbac tests, spaces can be managed with the SOC temporarily * Putting trimIdPrefix back to it's original name * Removing unused code and debug statements * Fixing some jsdocs * Removing unused type parameter * Another stray console.log... * Fixing repository provider test * Fixing repository tests * No longer exposing the namespace in get and bulkGet * Fixing SavedObjectClient tests, using more Symbols... It ends up that two different instances of {} are considered to be equal by jest's .toHaveBeenCalledWith, so for these white-box tests we're just using Symbols... * Fixing getSearchDsl tests * Removing filters, we don't use them anymore * Fixing query param tests * Adding Schema tests * Fixing secure saved objects client test * Namespaces via options * Removing duplicate test * Removing spaceId from mappings * Fixing test * Registering the namespace agnostic types using uiExports * Even better schema

[skip ci]

@alexfrancoeur

[skip ci] This PR improves the Space management experience when updating or deleting the user's active space. 1) When a user updates the space they are currently in, the Space Avatar in the Kibana nav will automatically update to match after saving. Fixes #22537 (cc @alexfrancoeur) 2) When a user **deletes** the space they are currently in, a secondary confirmation modal is displayed, warning them that they are deleting their active space, and they will be redirected to select another space: ![test](https://user-images.githubusercontent.com/3493255/44916585-22caf180-ad04-11e8-87c1-24538d2d6c2a.gif)

* Splitting to a client and a wrapper, integation tests are passing without spaces * Adding the spaces wrapper back in the mix using a priority collection * Restructuring the secure wrapper as we don't need to switch between repositories * Checking authorization at the current space * Beginning to make the rbac api integration tests run against spaces * Adding identical data to the rbac esArchives for two more spaces * Adding some space tests for find * Beginning to work on the spaces client * Fixing find and filtering out unrequested privileges from response * Adding get code and test * Introducing an RBAC Auth Scope * Exposing the spacesClient a bit better * Moving the server.expose to the security plugin init * Moving checkPrivilegesAtAllResources to it's own thing * No longer using the auth scope for RBAC, dashboard mode didn't work with it * Securing the create space method * Adding secure update method * Adding secured delete endpoints * Restructuring some code in the spaces client * Adding tests for the select endpoint * Spaces can't be managed via the SavedObjectsClient now * Creating separate space_all and space_read privileges * Splitting out the spaces and global privileges * Fixing edit role screen after API changes * Revising comment, there is a Set in JavaScript now, but lodash can't equal them * Using authorization mode to log deprecation warning on login * Changing the signature of checkPrivileges We're now using the legacy fallback when there are no application privileges. This improves performance at the sake of legacy 403s being displayed to users who have no application privileges. * Refactoring the way we specify resources when checking privileges * Exposing the space service more intuitively * Fixing comments * Security defines all actions * Renaming `response` returned by the checkPrivileges function * Hard-coding the kibana app privileges teporarily * Adding Authenticator authorization mode tests * Adding actions.manageSpaces tests * Adding check privileges tests * Fixing checkPrivileges test snapshots * Making sure tests fail until I correct this deficiency * Adding stubbed out authorization mode tests * Fixing tests for RegisterPrivilegesWithCluster * Fixing service AuthorizationService tests * Addinng serializer tests * Adding validateEsResponse tests * We don't need the SecureSavedObjectsClient anymore! * Adding SecureSavedObjectsClientWrapper tests... * Fixing a few stray tests * Fixing issue when user isn't authenticated and check useRbacForRequest * Validating spaces we're adding to roles * Reusing hasAnyPrivileges from hasAnyResourcePrivileges * Better variable name * toArray -> toPrioritizedArray * Using Space throughout the SpacesClient * GetActiveSpace uses the SpacesClient now * Squashed commit of the following: commit 23515b1 Author: kobelb <brandon.kobel@elastic.co> Date: Mon Sep 10 06:57:58 2018 -0400 Adding more users to the spaces tests commit 4bbde73 Author: kobelb <brandon.kobel@elastic.co> Date: Mon Sep 10 06:09:35 2018 -0400 Adding not space aware get tests commit 5d11bef Author: kobelb <brandon.kobel@elastic.co> Date: Sat Sep 8 14:06:20 2018 -0400 Adding not space aware test to find commit f9383fd Author: kobelb <brandon.kobel@elastic.co> Date: Sat Sep 8 13:49:04 2018 -0400 Adding bulk create tests and testing non space aware type with bulkGet commit 5388b5a Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 16:18:04 2018 -0400 Adding bulk create test commit 0674263 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 15:58:21 2018 -0400 Ignoring some modules commit 6b011d3 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 15:55:58 2018 -0400 Making the users match for saved objects security and spaces commit de2f994 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 14:18:53 2018 -0400 Making the space suites define their own test expectations commit 5407866 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:15:46 2018 -0400 Removing redundant spaces folder commit 9913923 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:14:45 2018 -0400 Removing unneeded objects from the esarchive commit bc602b1 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:08:12 2018 -0400 Moving some tests around commit 7fec308 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 12:38:23 2018 -0400 Deleting rbac_api_integration tests, they've been migrated elsewhere commit 29c018e Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 10:01:16 2018 -0400 Importing SuperTest where needed commit 38d2e74 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:44:53 2018 -0400 Removing the "saved_objects" folder commit 70eada4 Merge: 1b2708f 9023431 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Fri Sep 7 10:04:03 2018 -0400 Merge pull request #4 from legrego/spaces-api-tests Initial round of spaces api testing commit 9023431 Merge: 6410f72 1b2708f Author: Larry Gregory <larry.gregory@elastic.co> Date: Fri Sep 7 09:37:57 2018 -0400 Merge remote-tracking branch 'kobelb/spaces/securing-api-tests' into spaces-api-tests commit 1b2708f Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:17:25 2018 -0400 Even more typescript commit 369a429 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:08:28 2018 -0400 Typescriptifying Get commit f53f2ab Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:01:48 2018 -0400 Typescriptifying Find commit f707e03 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:55:10 2018 -0400 Typescriptifying Create commit 485d983 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:31:54 2018 -0400 Changing the namespace agnostic type name commit 71c2122 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:25:15 2018 -0400 Adding update tests commit f60e953 Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 15:53:34 2018 -0400 Delete tests commit 94682e5 Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 12:07:39 2018 -0400 Adding get security and spaces tests commit 481943f Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 11:58:42 2018 -0400 Generalizing bulk get commit 14d9058 Merge: 6627127 fc5f7fa Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Sep 6 10:46:07 2018 -0400 Merge pull request #3 from legrego/remove-privs-api Remove privs api and hardcoded privs list commit 6410f72 Author: Larry Gregory <larry.gregory@elastic.co> Date: Thu Sep 6 09:35:30 2018 -0400 add missing superagent type commit 4afacc0 Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 20:19:15 2018 -0400 initial round of spaces api testing commit 6627127 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 17:29:37 2018 -0400 Adding GET test suite commit 68a5537 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 13:32:49 2018 -0400 Copying find to security and spaces commit fc5f7fa Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 12:36:30 2018 -0400 move es privilege tests to api_integration commit 189fbe6 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 12:24:41 2018 -0400 Switching approach to dynamically enabling security commit c72200f Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 11:57:26 2018 -0400 remove get privileges api commit 1607f80 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 11:47:19 2018 -0400 Dynamically supplying users so we reduce some duplication commit 9deec1b Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 09:32:36 2018 -0400 Security and Spaces create tests commit a8232dd Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 07:22:10 2018 -0400 Using a create "test suite" commit f07f668 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 05:54:46 2018 -0400 Using the spaces esArchive always now commit b2021ad Merge: d3babea 7b4575b Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 05:43:48 2018 -0400 Merge branch 'spaces/securing' into spaces/securing-api-tests commit d3babea Author: kobelb <brandon.kobel@elastic.co> Date: Tue Sep 4 17:43:38 2018 -0400 Moving over the spaces only saved objects tests commit 94054a2 Author: kobelb <brandon.kobel@elastic.co> Date: Tue Sep 4 17:26:43 2018 -0400 Copying over the security only saved object api tests * update public api to use SpacesClient * fix * test and api fixes * fix tests * Disallowing use of Spaces with the SpacesSavedObjectsClientWrapper * Adding spaces audit logging * Updating snapshots * Adding get and getAll tests for the spaces client * Adding update tests * Adding create tests * Adding SpacesClient delete tests * Fixing authenticate tests * Making tests more consistent * Fixing kibana privileges tests * Fixing a few type issues * Making typescript ignore the .only test suites * Switching to beforeEach and afterEach and removing the mocha types * Switching to our own expect.js definitions The definitions in @types/expect have expect being globally defined which conflicts with the jest definitions, and expect isn't globally defined in the mocha tests and we must use the module value * Fixing more linting rules * Removing test stubs and replacing with TODOs. Updating snapshots * No longer shadowing application for the put role API * Relying on the errors thrown by the SpacedClient when determining active space * Back to after/before... mocha doesn't have beforeAll/afterAll * We got them types, thanks Spencer!!! * Ignoring space type from the secure saved objects client find with no type

…s-phase-1

* finishes TS conversion for the Spaces plugin

…sitory

…bject

…ase-1-namespaces

…spaces-with-migrations

…ase-1-namespaces

fields

…ase-1-namespaces

…23390) [skip ci] The Kibana server automatically creates the default space on startup. Before attempting to create, it checks to see if the default space already exists. If it exists, then Kibana won't proceed. If it doesn't exist, then it will attempt to create it. Given the async non-atomic nature of this operation, there are no guarantees that a subsequent invocation won't also try to create the default space. In this scenario, we were logging a superfluous conflict error. This PR suppresses the conflict error while allowing all other errors to be thrown.

Commits on Jul 19, 2018

Merge branch 'master' into spaces-phase-1

legrego committed Jul 19, 2018

Configuration menu

View commit details

Copy full SHA for 6fb21ee

Browse repository at this point

Copy the full SHA

6fb21ee View commit details

Browse the repository at this point in the history

Commits on Sep 27, 2018

Switching from a while loop to a findIndex

kobelb committed Sep 27, 2018

Configuration menu

View commit details

Copy full SHA for 0c3c099

Browse repository at this point

Copy the full SHA

0c3c099 View commit details

Browse the repository at this point in the history

Commits on Sep 28, 2018

Merge branch 'master' into spaces-phase-1

legrego committed Sep 28, 2018

Configuration menu

View commit details

Copy full SHA for e7dd8bf

Browse repository at this point

Copy the full SHA

e7dd8bf View commit details

Browse the repository at this point in the history

Spaces Phase 1 #21408

Spaces Phase 1 #21408

Commits on Apr 25, 2018

Commits on May 2, 2018

Commits on May 3, 2018

Commits on May 7, 2018

Commits on May 16, 2018

Commits on May 17, 2018

Commits on May 21, 2018

Commits on May 22, 2018

Commits on May 29, 2018

Commits on May 30, 2018

Commits on Jun 1, 2018

Commits on Jun 4, 2018

Commits on Jun 5, 2018

Commits on Jun 6, 2018

Commits on Jun 7, 2018

Commits on Jun 11, 2018

Commits on Jun 12, 2018

Commits on Jun 13, 2018

Commits on Jun 14, 2018

Commits on Jun 15, 2018

Commits on Jun 19, 2018

Commits on Jun 20, 2018

Commits on Jun 26, 2018

Commits on Jun 27, 2018

Commits on Jun 28, 2018

Commits on Jun 29, 2018

Commits on Jul 2, 2018

Commits on Jul 5, 2018

Commits on Jul 6, 2018

Commits on Jul 9, 2018

Commits on Jul 10, 2018

Commits on Jul 12, 2018

Commits on Jul 13, 2018

Commits on Jul 16, 2018

Commits on Jul 19, 2018

Commits on Jul 20, 2018

Commits on Jul 23, 2018

Commits on Jul 25, 2018

Commits on Jul 26, 2018

Commits on Jul 27, 2018

Commits on Jul 30, 2018

Commits on Jul 31, 2018

Commits on Aug 1, 2018

Commits on Aug 15, 2018

Commits on Aug 16, 2018

Commits on Aug 17, 2018

Commits on Aug 20, 2018

Commits on Aug 24, 2018

Commits on Aug 27, 2018

Commits on Aug 29, 2018

Commits on Aug 30, 2018

Commits on Sep 4, 2018

Commits on Sep 6, 2018

Commits on Sep 7, 2018

Commits on Sep 10, 2018

Commits on Sep 11, 2018

Commits on Sep 12, 2018

Commits on Sep 13, 2018

Commits on Sep 14, 2018

Commits on Sep 15, 2018

Commits on Sep 18, 2018

Commits on Sep 19, 2018

Commits on Sep 20, 2018

Commits on Sep 21, 2018

Commits on Sep 24, 2018

Commits on Sep 25, 2018

Commits on Sep 26, 2018

Commits on Sep 27, 2018

Commits on Sep 28, 2018