Test: canvas functional smoke test #25262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
added
v7.0.0
v6.5.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
|
@w33ble does the workpad have different data sources and can we add a test that we see the data of each type of data source. |
Yup, it tests esdocs and essql, using the logstash data. It doesn't test the output, but it certainly could. That's more than just a smoke test though, and testing expression output would be much faster (and easier) in unit tests. |
|
I really think a smoke test for Canvas should verify that we get data from all the data sources. I think it could be pretty easy on the data table. Or maybe even just a single metric number from each type? |
I agree, but it's much faster, and much easier, to do this as an integration test in the unit test pipeline. We don't need Kibana, or even a UI, to test that stuff. |
|
Here's an example of an issue this test could catch by having one of each type of data source and checking that the data appears; |
w33ble
force-pushed
the
test/canvas-functional-smoke-test
branch
3 times, most recently
from
4ba96f1
to
2d642a1
Compare
💚 Build Succeeded |
💚 Build Succeeded |
w33ble
force-pushed
the
test/canvas-functional-smoke-test
branch
from
6fda5b9
to
2954563
Compare
should help with some of the flakey behavior with the selectors
💚 Build Succeeded |
💚 Build Succeeded |
spalger
changed the title
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
|
|
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Nov 21, 2018
~~Blocked by elastic#23046 (pending elastic#25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
## Summary CI was broken when enabling functional smoke tests via #25262. The problem is that the Kibana build is broken in master... I think #25711 broke it, which was merged in between #25262 passing and it being merged (and then CI breaking). So this PR reverts that PR and enabled canvas smoke tests again to see if CI will pass. - Revert #25711 - Revert 7ae0d28
w33ble
added a commit
that referenced
this pull request
Nov 21, 2018
~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing 
w33ble
added a commit
that referenced
this pull request
Nov 22, 2018
* chore: revert #25921 / d76c0ae * Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * test: add ci group tags backport of #26046 * chore: shot in the dark beforeAll fix * chore: add some debug logging in the beforeAll hook, to see where it's getting stuck * [canvas/archive] remove _1 from .kibana archives to avoid lockup
w33ble
added a commit
that referenced
this pull request
Nov 22, 2018
* Test: canvas functional smoke test (#25262) ~~Blocked by #23046 (pending #25828 merged Adds functional smoke tests for Canvas. - Loads and checks the list of workpads - Loads the first workpad and checks that elements render This is the simple workpad it's testing  * [canvas/archive] remove _1 from .kibana archives to avoid lockup (cherry picked from commit d51e554)
|
@w33ble thanks! One question, does it use the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #23046 (pending #25828)mergedAdds functional smoke tests for Canvas.
This is the simple workpad it's testing