darwin binaries will not run on freebsd/openbsd #27255
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both phantomjs and chromium include
freebsd
andopenbsd
as targets on which the Darwin builds can be deployed. This is nonsense as neither of those platforms can run Darwin binaries../bin/phantomjs: cannot execute binary file: Exec format error
The result of removing
*bsd
from the Darwin target is that now kibana will die with this error:Unsupported platform: freebsd
instead of this error:
Failed to install browser. See kibana logs for more details.
That's much more accurate.
If adding support for FreeBSD and OpenBSD is desirable, the Right Way to do it is to depend on an OS supplied (via ports/packages) binary.
I have started looking into convincing the reporting module to use an installed binary. If I figure it out before running out of time, I'll create another PR.
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers