add typings for mocha #30190

vitalics · 2019-02-06T10:55:18Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

timroes

Code LGTM

elasticmachine · 2019-02-06T11:08:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Remebered the Jest Mocha typing clash

timroes · 2019-02-06T11:16:02Z

@elastic/kibana-platform I am not sure if adding mocha types works like that? Jest typings already define a describe and it on the top level, so if we pull in mocha typings those will suddenly collide. I think we would somehow need to make sure that the jest typing is only valid for jest files and the mocha typing for mocha types. Any idea how this can be achieved?

elasticmachine · 2019-02-06T12:53:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

try to fix ci

elasticmachine · 2019-02-06T15:24:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger · 2019-02-08T02:26:19Z

packages/kbn-config-schema/tsconfig.json

-    "target"
-  ]
-}
+{


This and the other config files were updated to use different line endings, please update your git config to preserve the line endings that were in the file: https://help.github.com/articles/dealing-with-line-endings/#global-settings-for-line-endings

I also recommend installing the editorconfig plugin for your editor so it will automatically pickup configuration files like https://github.com/elastic/kibana/blob/master/.editorconfig

spalger

Please supply some description for the intention behind this change, best I can tell this has no effect other than listing @types/mocha in the root package.json when it's not necessary.

package.json

elasticmachine · 2019-02-08T03:22:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger · 2019-02-08T20:54:43Z

@vitalics comment here with a little bit more information about your local setup and I'll try to reproduce it locally to see how we can get those errors gone from your setup, but I'm 90% sure we don't need this unnecessary dependency and the tsconfig changes to accomplish it, so I'm closing this PR

What branch are you developing on?
Are you developing plugins? Can you share the source?
What editor are you using?
Do you have any Typescript specific editor configuration/plugins?

spalger · 2019-02-15T17:00:38Z

Okay, seems like this is something we do need really soon, so lets go ahead and get this merged.

elasticmachine · 2019-02-15T17:50:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Working to get this merged by using it in the kibana functional tests

elasticmachine · 2019-02-15T19:19:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-02-15T21:07:56Z

test/tsconfig.json

+  "extends": "../tsconfig.json",
+  "compilerOptions": {
+    "types": [
+      "@kbn/test/types/expect.js",


@timroes the expect.js types from npm define a global expect variable, which I assume is important for some usages of the library, but is colliding poorly in the Kibana repo where expect.js and jest need to coexist. Since we are somewhat special in this regard and expect.js is effectively done, I copied the type definition into @kbn/test, changed it to a simple module type, and referenced it from the relevant config files. It won't have the same autoloading benefits of a @types/ package, but I think it's a suitable solution for the problem. Do you agree?

I think that's a good behavior for now, and I currently don't see a reason why it should be bad.

elasticmachine · 2019-02-15T21:58:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-16T23:49:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes · 2019-02-18T08:14:26Z

test/functional/apps/console/index.ts

-export default function ({ getService, loadTestFile }) {
+import { FtrProviderContext } from '../../../types';
+
+// tslint:disable-next-line no-default-export


Could we perhaps disable this check completely for the function tests, since it's just the way the functional test framework has been build and even new test files will have to use that, so I think we should rather disable it in tslint for the test folder than to force every file to have that tslint disable in it, since I think an inline tslint-disable should be for exceptional cases, and ideally should go with a comment why it needs to be disabled there. This is not an exceptional case, but the expected behavior.

Not really, tslint doesn't support overrides for patterns or anything like eslint does.

When https://github.com/typescript-eslint/typescript-eslint is ready and we move to it we will be able to, but until then this is our best option without dropping tslint.yaml files all over the place with I think is even worse. palantir/tslint#3447 (comment)

vitalics · 2019-02-25T07:03:41Z

I suppose we need to close this PR since #31234 is already merged and closed

…onfig files (#31948) In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.

…onfig files (elastic#31948) In elastic#31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from elastic#30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.

…onfig files (#31948) (#32250) In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests.

…onfig files (elastic#31948) In elastic#31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from elastic#30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests. # Conflicts: # src/functional_test_runner/lib/config/schema.js # test/common/services/es.ts # test/functional/page_objects/index.ts # test/functional/services/apps_menu.js # yarn.lock

…32827) * [ts] add script to verify that all ts is in a project (#32727) Based on #32705 We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI. * tests typescript migration (#31234) * add typescript support for functional tests * [ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files (#31948) In #31234 there were some extra changes that I've reverted, like use of the `tsconfig-paths` package to magically rewrite import statements to defy the standard node module resolution algorithm, the inclusion of several unnecessary options in the `test/tsconfig.json` file, and changes of the line-endings in the config files. This also brings a few enhancements from #30190 including a modularized version of the expect.js types, and options for explicit mappings for the PageObjects and services used in ftr tests. # Conflicts: # src/functional_test_runner/lib/config/schema.js # test/common/services/es.ts # test/functional/page_objects/index.ts # test/functional/services/apps_menu.js # yarn.lock

remove typings

84afc13

vitalics requested review from timroes, markov00 and dilchenko February 6, 2019 10:58

timroes previously approved these changes Feb 6, 2019

View reviewed changes

add jest types for removing mocha collision

52d4d10

add typings for global tsconfig

67b9fc4

try to fix ci

timroes requested a review from a team February 6, 2019 15:28

spalger reviewed Feb 8, 2019

View reviewed changes

spalger added 2 commits February 7, 2019 18:26

Merge branch 'master' of github.com:elastic/kibana into pr/30190

c1341b3

fix line-endings

ce62ec5

spalger previously requested changes Feb 8, 2019

View reviewed changes

package.json Show resolved Hide resolved

spalger closed this Feb 8, 2019

vitalics mentioned this pull request Feb 14, 2019

tests typescript migration #31107

Closed

7 tasks

spalger reopened this Feb 15, 2019

spalger mentioned this pull request Feb 15, 2019

[Uptime] Add functional UI tests #29667

Merged

Merge branch 'master' of github.com:elastic/kibana into tests-types

d0a15ea

[ftr] add ts support and use in console tests

d292d64

spalger requested a review from timroes February 15, 2019 18:29

spalger added 2 commits February 15, 2019 13:04

[types] move expect.js types into repo, remove global type

07780c9

Merge branch 'master' of github.com:elastic/kibana into tests-types

9952973

spalger reviewed Feb 15, 2019

View reviewed changes

spalger mentioned this pull request Feb 16, 2019

[canvas] TS Asset Manager + Stories #31341

Merged

6 tasks

Merge branch 'master' of github.com:elastic/kibana into tests-types

b18dd37

spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v8.0.0 v7.2.0 labels Feb 17, 2019

timroes reviewed Feb 18, 2019

View reviewed changes

vitalics closed this Feb 25, 2019

spalger mentioned this pull request Feb 25, 2019

[ts][ftr] improve types for ftr and expect.js, cleanup changes to tsconfig files #31948

Merged

spalger deleted the tests-types branch May 30, 2019 06:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add typings for mocha #30190

add typings for mocha #30190

vitalics commented Feb 6, 2019

timroes left a comment

elasticmachine commented Feb 6, 2019

timroes commented Feb 6, 2019

elasticmachine commented Feb 6, 2019

elasticmachine commented Feb 6, 2019

spalger Feb 8, 2019

spalger Feb 8, 2019

spalger left a comment

elasticmachine commented Feb 8, 2019

spalger commented Feb 8, 2019

spalger commented Feb 15, 2019

elasticmachine commented Feb 15, 2019

elasticmachine commented Feb 15, 2019

spalger Feb 15, 2019

timroes Feb 18, 2019

elasticmachine commented Feb 15, 2019

elasticmachine commented Feb 16, 2019

timroes Feb 18, 2019

spalger Feb 19, 2019 •

edited

Loading

vitalics commented Feb 25, 2019 •

edited

Loading

add typings for mocha #30190

add typings for mocha #30190

Conversation

vitalics commented Feb 6, 2019

Summary

Checklist

For maintainers

timroes left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 6, 2019

💔 Build Failed

timroes commented Feb 6, 2019

elasticmachine commented Feb 6, 2019

💔 Build Failed

elasticmachine commented Feb 6, 2019

💚 Build Succeeded

spalger Feb 8, 2019

Choose a reason for hiding this comment

spalger Feb 8, 2019

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 8, 2019

💚 Build Succeeded

spalger commented Feb 8, 2019

spalger commented Feb 15, 2019

elasticmachine commented Feb 15, 2019

💚 Build Succeeded

elasticmachine commented Feb 15, 2019

💔 Build Failed

spalger Feb 15, 2019

Choose a reason for hiding this comment

timroes Feb 18, 2019

Choose a reason for hiding this comment

elasticmachine commented Feb 15, 2019

💚 Build Succeeded

elasticmachine commented Feb 16, 2019

💚 Build Succeeded

timroes Feb 18, 2019

Choose a reason for hiding this comment

spalger Feb 19, 2019 • edited Loading

Choose a reason for hiding this comment

vitalics commented Feb 25, 2019 • edited Loading

spalger Feb 19, 2019 •

edited

Loading

vitalics commented Feb 25, 2019 •

edited

Loading