Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests typescript migration #31107

Closed
wants to merge 8 commits into from
Closed

tests typescript migration #31107

wants to merge 8 commits into from

Conversation

vitalics
Copy link
Contributor

Summary

add typescript support and not breaking previous tests
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@vitalics vitalics self-assigned this Feb 14, 2019
@vitalics vitalics added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@vitalics
Copy link
Contributor Author

vitalics commented Feb 14, 2019

I suppose that it will be based on #30190 since tests in the test folder confusing with jest typings

@vitalics
Copy link
Contributor Author

This pr also have changes in various packages, hence I pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💔 Build Failed

@vitalics vitalics requested review from a team as code owners February 14, 2019 13:03
@vitalics vitalics added the Team:QA Team label for QA Team label Feb 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa

@vitalics vitalics added the WIP Work in progress label Feb 14, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@vitalics vitalics closed this Feb 15, 2019
@vitalics vitalics deleted the typescript-migration branch February 15, 2019 09:02
@vitalics vitalics mentioned this pull request Feb 15, 2019
7 tasks
@vitalics vitalics mentioned this pull request Feb 25, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:QA Team label for QA Team Team:Visualizations Visualization editors, elastic-charts and infrastructure test_infra test_ui_functional WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants