[7.0] Fix: show actual errors on failed elements, handle null values from functions (#32600) #32794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions (elastic#32600) Closes elastic#32356 This PR fixes two issues. The first there was an issue filed, elastic#32356: - Show non-Boom errors instead of asking users to look at server logs - Also write the error to the server when asking them to look there  *If the function failed for some reason, this is all you'd ever see*  *Errors are shown to the user*  *Code errors bubble up correctly as well* --- The other I didn't bother opening an issue for: - Fixes issue where functions that return `null` produce an error message - `null` is a valid thing to return, it's only `undefined` that causes a problem - This was only a problem for server functions that return `null` (currently, none of them do) - Introduced in elastic#31298 - Discovered when I ran into casting problems (see elastic#32597)  
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.0: