Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr/percy] integrate percy with functional test runner #32953

Closed
wants to merge 42 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 12, 2019

Testing out integrating Percy with the functional test runner: https://percy.io/Elastic/kibana-ftr

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@liza-mae
Copy link
Contributor

liza-mae commented May 3, 2019

@spalger can we make an official PR for this functionality?

@elasticmachine

This comment has been minimized.

@spalger
Copy link
Contributor Author

spalger commented May 20, 2019

Okay, it seems the flakiness might have actually just been coincidental... Going to give it a couple more goes.

@liza-mae
Copy link
Contributor

Thanks @spalger it is looking better.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor

Nice @spalger! Those changes look promising at fixing the chromium download failures.

@elastic elastic deleted a comment from elasticmachine May 22, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor

liza-mae commented Jun 4, 2019

@spalger can we please look to get this PR updated and merged or would you like me to merge my PR off of your PR? Please let me know.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger closed this Jun 13, 2019
@spalger spalger deleted the implement/percy-collector branch August 18, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants