[Monitoring] Fix 500 error from /api/stats #36986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring |
ycombinator
reviewed
May 23, 2019
ycombinator
reviewed
May 23, 2019
💔 Build Failed |
💚 Build Succeeded |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
* Fix 500 and add test for it * Return an empty object so the logic later will still execute * Update tests
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
* Fix 500 and add test for it * Return an empty object so the logic later will still execute * Update tests
This was referenced May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
* Fix 500 and add test for it * Return an empty object so the logic later will still execute * Update tests
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
* Fix 500 and add test for it * Return an empty object so the logic later will still execute * Update tests
This was referenced May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36943
Introduced by #35691
Added a test too. Fairly self-explanatory. Need to backport everywhere #35691 went