Upgrade enzyme and enzyme-adapter-react-16 to the latest #37064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
joshdover
approved these changes
May 24, 2019
7 tasks
💚 Build Succeeded |
spalger
approved these changes
May 28, 2019
|
|
||
| /* | ||
| The issue with enzyme@3.9.0 -> the fix has not been released yet -> https://github.com/airbnb/enzyme/pull/2027 | ||
| TODO: Enable the expectation after the next patch released |
There was a problem hiding this comment.
This module isn't being worked on a ton right now, would you mind adding something to your calendar to return to this in a couple weeks once the enzyme-adapter is updated?
There was a problem hiding this comment.
@spalger sure.
@sulemanof is on vacation, so I will track this.
💔 Build Failed |
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
May 29, 2019
* Upgrade enzyme and enzyme-adapter-react-16 to the latest * Skip failed expectation * Update yarn.lock * Update snapshot
maryia-lapata
added a commit
that referenced
this pull request
May 29, 2019
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
* Upgrade enzyme and enzyme-adapter-react-16 to the latest * Skip failed expectation * Update yarn.lock * Update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main purpose of this is an ability to test React functional components with Hooks API.
The necessity of writing such tests is in scope of EUIfication of an old vis editor #30922
Checklist
For maintainers