[Discover] Prevent whitespace wrapping of doc table header #52861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…-12-discover-table-header-wrap
|
@elasticmachine merge upstream |
kertal
added
release_note:fix
v7.9.0
v8.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
snide
reviewed
May 8, 2020
snide
reviewed
May 8, 2020
src/plugins/discover/public/application/angular/doc_table/components/_table_header.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Yes, there's a problem with very long fields that define the width of the column here, but that's not that easy to fix, so it's up to our DataGrid then. |
stratoula
approved these changes
May 8, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 8, 2020
…2861) Co-authored-by: Dave Snider <dave.snider@gmail.com>
kertal
added a commit
that referenced
this pull request
May 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves legacy doc table whitespace wrapping used in Discover and Dashboard. Will be redundant with #51531, but since it's a pretty simple fix, and looks much better this way, let's improve it a bit earlier.
Before:
After:
Fixes: #56529