Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount ui/new_platform applications in same div structure as Core #63930

Merged
merged 3 commits into from
May 10, 2020
Merged

Mount ui/new_platform applications in same div structure as Core #63930

merged 3 commits into from
May 10, 2020

Conversation

joshdover
Copy link
Contributor

Summary

This ensures that legacy apps that utilize the ui/new_platform bridge are mounted in the same DOM structure as true KP apps.

Dev Docs

Applications that are mounted via the core.application.register interface from the legacy ui/new_platform module are now mounted inside a new div inside of the <div class="application /> node rather than directly inside that node. This makes the legacy bridge consistent with how true KP applications are mounted.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.8.0 labels Apr 19, 2020
@joshdover joshdover requested a review from crob611 April 19, 2020 18:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover
Copy link
Contributor Author

@crob611 I'm guessing this is failing for the same reason that you were having troubling migrating Canvas over?

@crob611
Copy link
Contributor

crob611 commented Apr 20, 2020

Yes, this "breaks" the rendering of Canvas through ui/new_platform the same way it happens through the actual KP.

Should the kibana theme be updated to account for this new rendering structure? (I'm not sure where that theme comes from). Should the div created inside of .application get some class identifier?

@joshdover
Copy link
Contributor Author

Should the kibana theme be updated to account for this new rendering structure? (I'm not sure where that theme comes from)

I'm not sure what theme you're talking about?

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it changes legacy to match KP.

I don't see any reason why this should be causing the smoke test to fail. I can't see any selectors that should be affected by this, but I can dig in if I need to.

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover joshdover added v7.9.0 and removed v7.8.0 labels May 7, 2020
@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 8 times on tracked branches: https://github.com/elastic/kibana/issues/65949

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook
[00:07:08]           └-: sample data dashboard
[00:07:08]             └-> "before all" hook
[00:07:08]             └-> "before all" hook
[00:07:08]               │ debg ... sleep(5000) start
[00:07:13]               │ debg ... sleep(5000) end
[00:07:13]               │ debg navigateToUrl http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:13]               │ debg browser[INFO] http://localhost:6181/app/kibana?_t=1589128522800#/home/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:13]               │
[00:07:13]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:13]               │ debg currentUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:13]               │          appUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:07:13]               │ debg TestSubjects.find(kibanaChrome)
[00:07:13]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:07:17]               │ debg isGlobalLoadingIndicatorVisible
[00:07:17]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:17]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:17]               │ debg browser[INFO] http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-10T16:35:26Z
[00:07:17]               │        Adding connection to http://localhost:6181/elasticsearch
[00:07:17]               │
[00:07:17]               │      "
[00:07:17]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:17]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:18]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:07:18]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:07:18]               │ debg TestSubjects.click(addSampleDataSetflights)
[00:07:18]               │ debg Find.clickByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:07:18]               │ debg Find.findByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:07:18]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:07:18]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:07:18]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] applying create index request using v1 templates []
[00:07:18]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [kibana_sample_data_flights] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:07:18]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] updating number_of_replicas to [0] for indices [kibana_sample_data_flights]
[00:07:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [.kibana_2/9jIs0CZVTciJnXpAtAfGTQ] update_mapping [_doc]
[00:07:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [.kibana_2/9jIs0CZVTciJnXpAtAfGTQ] update_mapping [_doc]
[00:07:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [.kibana_2/9jIs0CZVTciJnXpAtAfGTQ] update_mapping [_doc]
[00:07:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [.kibana_2/9jIs0CZVTciJnXpAtAfGTQ] update_mapping [_doc]
[00:07:26]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:07:26]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:07:28]               │ debg --- retry.tryForTime error: [data-test-subj="addSampleDataSetflights"] is not displayed
[00:07:29]               │ debg applying update to kibana config: {"timepicker:quickRanges":"[\n        {\n          \"from\": \"now-30d\",\n          \"to\": \"now+40d\",\n          \"display\": \"sample data range\"\n        },\n        {\n          \"from\": \"now/d\",\n          \"to\": \"now/d\",\n          \"display\": \"Today\"\n        },\n        {\n          \"from\": \"now/w\",\n          \"to\": \"now/w\",\n          \"display\": \"This week\"\n        },\n        {\n          \"from\": \"now-15m\",\n          \"to\": \"now\",\n          \"display\": \"Last 15 minutes\"\n        },\n        {\n          \"from\": \"now-30m\",\n          \"to\": \"now\",\n          \"display\": \"Last 30 minutes\"\n        },\n        {\n          \"from\": \"now-1h\",\n          \"to\": \"now\",\n          \"display\": \"Last 1 hour\"\n        },\n        {\n          \"from\": \"now-24h\",\n          \"to\": \"now\",\n          \"display\": \"Last 24 hours\"\n        },\n        {\n          \"from\": \"now-7d\",\n          \"to\": \"now\",\n          \"display\": \"Last 7 days\"\n        },\n        {\n          \"from\": \"now-30d\",\n          \"to\": \"now\",\n          \"display\": \"Last 30 days\"\n        },\n        {\n          \"from\": \"now-90d\",\n          \"to\": \"now\",\n          \"display\": \"Last 90 days\"\n        },\n        {\n          \"from\": \"now-1y\",\n          \"to\": \"now\",\n          \"display\": \"Last 1 year\"\n        }\n      ]"}
[00:07:29]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] [.kibana_2/9jIs0CZVTciJnXpAtAfGTQ] update_mapping [_doc]
[00:07:29]               │ debg click "Discover" app link
[00:07:29]               │ debg TestSubjects.exists(collapsibleNav)
[00:07:29]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:07:32]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:07:33]               │ debg TestSubjects.click(toggleNavButton)
[00:07:33]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:33]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:33]               │ debg TestSubjects.find(collapsibleNav)
[00:07:33]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:07:33]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:07:33]               │ debg browser[INFO] http://localhost:6181/app/kibana#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:33]               │
[00:07:33]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:36]               │ debg browser[INFO] http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-10T16:35:45Z
[00:07:36]               │        Adding connection to http://localhost:6181/elasticsearch
[00:07:36]               │
[00:07:36]               │      "
[00:07:36]               │ debg TestSubjects.click(indexPattern-switch-link)
[00:07:36]               │ debg Find.clickByCssSelector('[data-test-subj="indexPattern-switch-link"]') with timeout=10000
[00:07:36]               │ debg Find.findByCssSelector('[data-test-subj="indexPattern-switch-link"]') with timeout=10000
[00:07:37]               │ debg Find.clickByCssSelector('[data-test-subj="indexPattern-switcher"] [title="kibana_sample_data_flights"]') with timeout=10000
[00:07:37]               │ debg Find.findByCssSelector('[data-test-subj="indexPattern-switcher"] [title="kibana_sample_data_flights"]') with timeout=10000
[00:07:37]               │ debg isGlobalLoadingIndicatorVisible
[00:07:37]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:37]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:37]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:37]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:37]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:07:37]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:37]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:38]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_sample_data range)
[00:07:38]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:38]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:38]               │ debg isGlobalLoadingIndicatorVisible
[00:07:38]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:38]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:38]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:39]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:07:39]               │ debg TestSubjects.find(discoverQueryHits)
[00:07:39]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:07:39]             └-> should launch sample flights data set dashboard
[00:07:39]               └-> "before each" hook: global before each
[00:07:39]               │ debg click "Dashboard" app link
[00:07:39]               │ debg TestSubjects.exists(collapsibleNav)
[00:07:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:07:41]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:07:42]               │ debg TestSubjects.click(toggleNavButton)
[00:07:42]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:42]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:07:42]               │ debg TestSubjects.find(collapsibleNav)
[00:07:42]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:07:43]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:07:45]               │ debg Load Saved Dashboard [Flights] Global Flight Dashboard
[00:07:45]               │ debg gotoDashboardLandingPage
[00:07:45]               │ debg onDashboardLandingPage
[00:07:45]               │ debg TestSubjects.exists(dashboardLandingPage)
[00:07:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:07:45]               │ debg searchForItemWithName: [Flights] Global Flight Dashboard
[00:07:45]               │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:07:46]               │ debg isGlobalLoadingIndicatorVisible
[00:07:46]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:46]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:46]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:46]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:46]               │ debg TestSubjects.click(dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard)
[00:07:46]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard"]') with timeout=10000
[00:07:46]               │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard"]') with timeout=10000
[00:07:47]               │ debg isGlobalLoadingIndicatorVisible
[00:07:47]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:47]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:47]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:47]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:47]               │ debg TestSubjects.missingOrFail(dashboardLandingPage)
[00:07:47]               │ debg Find.waitForDeletedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=10000
[00:07:48]               │ debg browser[WARNING] http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 20:69562 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
[00:07:48]               │      Arguments: 
[00:07:48]               │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: now-24h, _f: undefined, _strict: undefined, _locale: [object Object]
[00:07:48]               │      Error
[00:07:48]               │          at Function.createFromInputFallback (http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:69970)
[00:07:48]               │          at http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:89720
[00:07:48]               │          at http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:89771
[00:07:48]               │          at Mt (http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90065)
[00:07:48]               │          at Ct (http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90442)
[00:07:48]               │          at St (http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:90524)
[00:07:48]               │          at r (http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21:66808)
[00:07:48]               │          at Function.convertTimeToUTCString (http://localhost:6181/33059/bundles/plugin/dashboard/dashboard.plugin.js:27:22213)
[00:07:48]               │          at Function.areTimesEqual (http://localhost:6181/33059/bundles/plugin/dashboard/dashboard.plugin.js:27:22401)
[00:07:48]               │          at DashboardStateManager.getTimeChanged (http://localhost:6181/33059/bundles/plugin/dashboard/dashboard.plugin.js:82:103161)"
[00:07:48]               │ debg isGlobalLoadingIndicatorVisible
[00:07:48]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:07:48]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:07:48]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:07:53]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:07:53]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:53]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:07:54]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_sample_data range)
[00:07:54]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:54]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_sample_data range"]') with timeout=10000
[00:07:56]               │ debg browser[INFO] http://localhost:6181/33059/bundles/plugin/visTypeVega/0.plugin.js 0:13090 "%cWelcome to Kibana Vega Plugin!" "font-size: 16px; font-weight: bold;"
[00:07:56]               │ debg browser[INFO] http://localhost:6181/33059/bundles/plugin/visTypeVega/0.plugin.js 0:13176 "You can access the Vega view with VEGA_DEBUG. Learn more at https://vega.github.io/vega/docs/api/debugging/."
[00:07:57]               │ debg isGlobalLoadingIndicatorVisible
[00:07:57]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:07:57]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:01]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:01]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:01]               │ debg Renderable.waitForRender for 1 elements
[00:08:01]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:02]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:03]               │ debg Checking pie charts rendered
[00:08:03]               │ debg PieChart.expectPieSliceCount(4)
[00:08:03]               │ debg PieChart.getPieSliceCount
[00:08:03]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:03]               │ debg click "Discover" app link
[00:08:03]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:03]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:05]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:06]               │ debg TestSubjects.click(toggleNavButton)
[00:08:06]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:06]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:07]               │ debg TestSubjects.find(collapsibleNav)
[00:08:07]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:11]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:13]               │ debg isGlobalLoadingIndicatorVisible
[00:08:13]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:13]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:15]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:15]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:15]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:15]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:15]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:15]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:15]               │ debg click "Dashboard" app link
[00:08:15]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:15]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:18]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:18]               │ debg TestSubjects.click(toggleNavButton)
[00:08:18]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:18]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:19]               │ debg TestSubjects.find(collapsibleNav)
[00:08:19]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:19]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:19]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:08:19]               │ debg isGlobalLoadingIndicatorVisible
[00:08:19]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:19]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:20]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:20]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:26]               │ debg Renderable.waitForRender for 1 elements
[00:08:26]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:26]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:27]               │ debg Checking pie charts rendered
[00:08:27]               │ debg PieChart.expectPieSliceCount(4)
[00:08:27]               │ debg PieChart.getPieSliceCount
[00:08:27]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:27]               └- ✓ pass  (48.3s) "dashboard sample data dashboard should launch sample flights data set dashboard"
[00:08:27]             └-> toggle from Discover to Dashboard attempt 1
[00:08:27]               └-> "before each" hook: global before each
[00:08:27]               │ debg click "Discover" app link
[00:08:27]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:30]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:30]               │ debg TestSubjects.click(toggleNavButton)
[00:08:30]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:30]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:31]               │ debg TestSubjects.find(collapsibleNav)
[00:08:31]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:32]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:34]               │ debg isGlobalLoadingIndicatorVisible
[00:08:34]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:34]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:36]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:36]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:36]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:36]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:36]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:36]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:36]               │ debg click "Dashboard" app link
[00:08:36]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:36]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:39]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:39]               │ debg TestSubjects.click(toggleNavButton)
[00:08:39]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:39]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:40]               │ debg TestSubjects.find(collapsibleNav)
[00:08:40]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:40]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:40]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:08:40]               │ debg isGlobalLoadingIndicatorVisible
[00:08:40]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:40]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:40]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:40]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] to [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] to [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] in policy [kibana-event-log-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"pause-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] in policy [kibana-event-log-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"close-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] in policy [kibana-event-log-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"unfollow-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] in policy [kibana-event-log-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"open-follower-index"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] in policy [kibana-event-log-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:08:41]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1589125627083975678] moving index [.kibana-event-log-8.0.0-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-yellow-step"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [kibana-event-log-policy]
[00:08:46]               │ debg Renderable.waitForRender for 1 elements
[00:08:46]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:08:46]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:08:47]               │ debg Checking pie charts rendered
[00:08:47]               │ debg PieChart.expectPieSliceCount(4)
[00:08:47]               │ debg PieChart.getPieSliceCount
[00:08:47]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:08:47]               └- ✓ pass  (20.2s) "dashboard sample data dashboard toggle from Discover to Dashboard attempt 1"
[00:08:47]             └-> toggle from Discover to Dashboard attempt 2
[00:08:47]               └-> "before each" hook: global before each
[00:08:47]               │ debg click "Discover" app link
[00:08:47]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:47]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:50]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:50]               │ debg TestSubjects.click(toggleNavButton)
[00:08:50]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:50]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:51]               │ debg TestSubjects.find(collapsibleNav)
[00:08:51]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:08:52]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:08:54]               │ debg isGlobalLoadingIndicatorVisible
[00:08:54]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:08:54]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:08:56]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:08:56]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:08:56]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:08:56]               │ debg TestSubjects.getVisibleText(discoverQueryHits)
[00:08:56]               │ debg TestSubjects.find(discoverQueryHits)
[00:08:56]               │ debg Find.findByCssSelector('[data-test-subj="discoverQueryHits"]') with timeout=10000
[00:08:56]               │ debg click "Dashboard" app link
[00:08:56]               │ debg TestSubjects.exists(collapsibleNav)
[00:08:56]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:08:59]               │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:08:59]               │ debg TestSubjects.click(toggleNavButton)
[00:08:59]               │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:08:59]               │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:09:00]               │ debg TestSubjects.find(collapsibleNav)
[00:09:00]               │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:09:00]               │ debg Find.existsByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=2500
[00:09:00]               │ debg Find.findByCssSelector('[data-test-subj=collapsibleNav] > button') with timeout=10000
[00:09:00]               │ debg isGlobalLoadingIndicatorVisible
[00:09:00]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:00]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:00]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:00]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:07]               │ debg Renderable.waitForRender for 1 elements
[00:09:07]               │ debg Find.allByCssSelector('[data-render-complete="true"]') with timeout=10000
[00:09:07]               │ debg Find.allByCssSelector('[data-loading]') with timeout=1000
[00:09:08]               │ debg Checking pie charts rendered
[00:09:08]               │ debg PieChart.expectPieSliceCount(4)
[00:09:08]               │ debg PieChart.getPieSliceCount
[00:09:08]               │ debg Find.allByCssSelector('svg > g > g.arcs > path.slice') with timeout=2500
[00:09:08]               │ debg Checking area, bar and heatmap charts rendered
[00:09:08]               │ debg DashboardExpect.seriesElementCount(15)
[00:09:08]               │ debg Find.allByCssSelector('.series') with timeout=2500
[00:09:08]               │ debg Checking saved searches rendered
[00:09:08]               │ debg DashboardExpect.savedSearchRowCount(50)
[00:09:08]               │ debg TestSubjects.findAll(docTableExpandToggleColumn)
[00:09:08]               │ debg Find.allByCssSelector('[data-test-subj="docTableExpandToggleColumn"]') with timeout=2500
[00:09:08]               │ debg Checking input controls rendered
[00:09:08]               │ debg DashboardExpect.inputControlItemCount(3)
[00:09:08]               │ debg TestSubjects.findAll(inputControlItem)
[00:09:08]               │ debg Find.allByCssSelector('[data-test-subj="inputControlItem"]') with timeout=10000
[00:09:09]               │ debg Checking tag cloud rendered
[00:09:09]               │ debg DashboardExpect.tagCloudWithValuesFound(Sunny,Rain,Clear,Cloudy,Hail)
[00:09:09]               │ debg TestSubjects.findAll(tagCloudVisualization)
[00:09:09]               │ debg Find.allByCssSelector('[data-test-subj="tagCloudVisualization"]') with timeout=10000
[00:09:09]               │ debg TestSubjects.descendantExists(Sunny)
[00:09:09]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Sunny"]') with timeout=2500
[00:09:09]               │ debg TestSubjects.descendantExists(Rain)
[00:09:09]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Rain"]') with timeout=2500
[00:09:09]               │ debg TestSubjects.descendantExists(Clear)
[00:09:09]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Clear"]') with timeout=2500
[00:09:09]               │ debg TestSubjects.descendantExists(Cloudy)
[00:09:09]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Cloudy"]') with timeout=2500
[00:09:09]               │ debg TestSubjects.descendantExists(Hail)
[00:09:09]               │ debg Find.descendantExistsByCssSelector('[data-test-subj="Hail"]') with timeout=2500
[00:09:09]               │ debg Checking vega chart rendered
[00:09:09]               │ debg Find.existsByCssSelector('.vgaVis__view') with timeout=2500
[00:09:09]               └- ✓ pass  (21.3s) "dashboard sample data dashboard toggle from Discover to Dashboard attempt 2"
[00:09:09]             └-> "after all" hook
[00:09:09]               │ debg navigateToUrl http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:09:09]               │ debg browser[INFO] http://localhost:6181/app/kibana?_t=1589128638888#/home/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:09]               │
[00:09:09]               │ debg browser[INFO] http://localhost:6181/bundles/app/kibana/bootstrap.js 10:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:09]               │ debg currentUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:09:09]               │          appUrl = http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:09:09]               │ debg TestSubjects.find(kibanaChrome)
[00:09:09]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:13]               │ debg TestSubjects.click(removeSampleDataSetflights)
[00:09:13]               │ debg Find.clickByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:09:13]               │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:09:13]               │ debg browser[INFO] http://localhost:6181/33059/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-05-10T16:37:21Z
[00:09:13]               │        Adding connection to http://localhost:6181/elasticsearch
[00:09:13]               │
[00:09:13]               │      "
[00:09:14]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:09:14]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:09:15]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:15]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:18]               │ debg --- retry.tryForTime error: [data-test-subj="addSampleDataSetflights"] is not displayed
[00:09:18]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard sample data dashboard _after all_ hook.png"
[00:09:18]               │ info Current URL is: http://localhost:6181/app/kibana#/home/tutorial_directory/sampleData
[00:09:18]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard sample data dashboard _after all_ hook.html
[00:09:18]               └- ✖ fail: "dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2""
[00:09:18]               │

Stack Trace

Error: expected true to equal false
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.after (test/functional/apps/dashboard/_async_dashboard.ts:109:30)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 1c554d9 into elastic:master May 10, 2020
@joshdover joshdover deleted the np/fix-compat-app-service branch May 10, 2020 20:00
@joshdover joshdover mentioned this pull request May 10, 2020
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request May 10, 2020
@joshdover
Mount ui/new_platform applications in same div structure as Core (ela…
ebc66a0 
…stic#63930)
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 11, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-components
74f076f 
* master: (58 commits)
  [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628)
  fix double flyouts in add panel flow (elastic#65861)
  Point 7.x to 7.9.0 in .backportrc.json
  Mount ui/new_platform applications in same div structure as Core (elastic#63930)
  [Uptime] Settings threshold validation (elastic#65454)
  Fix edit alert flyout to update initialAlert after edit (elastic#65359)
  Fix anomalies display on focused APM service map (elastic#65882)
  [SIEM][Detection Engine] Increases the template limit for ECS mappings
  [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851)
  [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579)
  [ML] Add job timing stats to anomaly jobs (elastic#65696)
  restore index pattern management data-test-subj's (elastic#64697)
  [Discover] Prevent whitespace wrapping of doc table header (elastic#52861)
  [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789)
  Skipping failing tests. elastic#65867 elastic#65866 elastic#65865
  [Discover] Deangularize the hits counter and create a react component (elastic#65631)
  Tsvb less update (elastic#65467)
  [TSVB] Remove remaining lodash.set usage (elastic#65846)
  [Uptime] Add `a11y` tests (elastic#65514)
  [Uptime] Enable loading on monitor list (elastic#65670)
  ...
joshdover added a commit that referenced this pull request May 11, 2020
@joshdover
[7.x] Mount ui/new_platform applications in same div structure as Core (
a7e3865 
#63930) (#65958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshdover @elasticmachine @crob611 @kibanamachine @pgayvallet