Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore index pattern management data-test-subj's #64697

Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 28, 2020

Summary

Reverting some data-test-subj attributes that were changed in #64184

@mattkime mattkime requested a review from a team as a code owner April 28, 2020 20:13
@elastic elastic deleted a comment from kibanamachine May 4, 2020
@mattkime
Copy link
Contributor Author

mattkime commented May 8, 2020

@elasticmachine merge upstream

@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2020
@alexwizp alexwizp added this to In progress in kibana-app-arch via automation May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added the Feature:Index Management Index and index templates UI label May 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibana-app-arch automation moved this from In progress to Review in progress May 8, 2020
@mattkime mattkime merged commit 97561d6 into elastic:master May 8, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release May 8, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request May 8, 2020
* restore index pattern management data-test-subj's
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I didn't test but the code looks right and Jenkins was happy. Thanks! :-)

mattkime added a commit that referenced this pull request May 8, 2020
* restore index pattern management data-test-subj's
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 11, 2020
* master: (58 commits)
  [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628)
  fix double flyouts in add panel flow (elastic#65861)
  Point 7.x to 7.9.0 in .backportrc.json
  Mount ui/new_platform applications in same div structure as Core (elastic#63930)
  [Uptime] Settings threshold validation (elastic#65454)
  Fix edit alert flyout to update initialAlert after edit (elastic#65359)
  Fix anomalies display on focused APM service map (elastic#65882)
  [SIEM][Detection Engine] Increases the template limit for ECS mappings
  [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851)
  [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579)
  [ML] Add job timing stats to anomaly jobs (elastic#65696)
  restore index pattern management data-test-subj's (elastic#64697)
  [Discover] Prevent whitespace wrapping of doc table header (elastic#52861)
  [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789)
  Skipping failing tests. elastic#65867 elastic#65866 elastic#65865
  [Discover] Deangularize the hits counter and create a react component (elastic#65631)
  Tsvb less update (elastic#65467)
  [TSVB] Remove remaining lodash.set usage (elastic#65846)
  [Uptime] Add `a11y` tests (elastic#65514)
  [Uptime] Enable loading on monitor list (elastic#65670)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Development

Successfully merging this pull request may close these issues.

None yet

6 participants