Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add job timing stats to anomaly jobs #65696

Merged
merged 5 commits into from
May 8, 2020
Merged

[ML] Add job timing stats to anomaly jobs #65696

merged 5 commits into from
May 8, 2020

Conversation

qn895
Copy link
Member

@qn895 qn895 commented May 7, 2020 •
edited by peteharverson
Loading

Summary

This PR fixes #55999 by adding the missing job timing stats to the Counts and JSON viewer tabs for anomaly detection jobs.

2020-04-30 at 10 191 AM

2020-04-30 at 10 19 AM

Making this again because I totally failed at rebasing for my first PR #64915

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@qn895 qn895 requested a review from a team as a code owner May 7, 2020 14:28
@qn895 qn895 self-assigned this May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson changed the title Add job timing stats to anomaly jobs [ML] Add job timing stats to anomaly jobs May 7, 2020
@peteharverson
Copy link
Contributor

I think one more bit of work is needed for this - job clone is failing:

image

I think you just need to delete the timing_stats part of the config in cloneJob in public/application/services/job_service.js.

@qn895
Copy link
Member Author

qn895 commented May 7, 2020

I was able to fix that issue but modified it in the following path
2020-05-07 at 11 21 AM

I can fix the issue inside server/job_service if that's preferred.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

walterra
walterra approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also did a local test and can confirm job cloning works! 🎉

@qn895 qn895 merged commit d3b155f into elastic:master May 8, 2020
This was referenced May 8, 2020
Merged
Merged
qn895 added a commit to qn895/kibana that referenced this pull request May 8, 2020
@qn895
[ML] Add job timing stats to anomaly jobs (elastic#65696)
9a53c32 
* [ML] Add anomaly job timing stats to Counts & JSON

* [ML] Remove roundTo3DecimalPlace and clean up

* [ML] Fix format_values to round decimals for time values

* [ML] Remove timing_stats and forecast_stats from cloneJob

* [ML] Remove timing_stats & forecasts in job_service instead of utils
qn895 added a commit to qn895/kibana that referenced this pull request May 8, 2020
@qn895
[ML] Add job timing stats to anomaly jobs (elastic#65696)
05021c2 
* [ML] Add anomaly job timing stats to Counts & JSON

* [ML] Remove roundTo3DecimalPlace and clean up

* [ML] Fix format_values to round decimals for time values

* [ML] Remove timing_stats and forecast_stats from cloneJob

* [ML] Remove timing_stats & forecasts in job_service instead of utils
qn895 added a commit that referenced this pull request May 8, 2020
@qn895
[ML] Add job timing stats to anomaly jobs (#65696) (#65891)
6e90ec9 
* [ML] Add anomaly job timing stats to Counts & JSON

* [ML] Remove roundTo3DecimalPlace and clean up

* [ML] Fix format_values to round decimals for time values

* [ML] Remove timing_stats and forecast_stats from cloneJob

* [ML] Remove timing_stats & forecasts in job_service instead of utils
qn895 added a commit that referenced this pull request May 8, 2020
@qn895
[ML] Add job timing stats to anomaly jobs (#65696) (#65890)
ace2d1e 
* [ML] Add anomaly job timing stats to Counts & JSON

* [ML] Remove roundTo3DecimalPlace and clean up

* [ML] Fix format_values to round decimals for time values

* [ML] Remove timing_stats and forecast_stats from cloneJob

* [ML] Remove timing_stats & forecasts in job_service instead of utils
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 11, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-components
74f076f 
* master: (58 commits)
  [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628)
  fix double flyouts in add panel flow (elastic#65861)
  Point 7.x to 7.9.0 in .backportrc.json
  Mount ui/new_platform applications in same div structure as Core (elastic#63930)
  [Uptime] Settings threshold validation (elastic#65454)
  Fix edit alert flyout to update initialAlert after edit (elastic#65359)
  Fix anomalies display on focused APM service map (elastic#65882)
  [SIEM][Detection Engine] Increases the template limit for ECS mappings
  [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851)
  [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579)
  [ML] Add job timing stats to anomaly jobs (elastic#65696)
  restore index pattern management data-test-subj's (elastic#64697)
  [Discover] Prevent whitespace wrapping of doc table header (elastic#52861)
  [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789)
  Skipping failing tests. elastic#65867 elastic#65866 elastic#65865
  [Discover] Deangularize the hits counter and create a react component (elastic#65631)
  Tsvb less update (elastic#65467)
  [TSVB] Remove remaining lodash.set usage (elastic#65846)
  [Uptime] Add `a11y` tests (elastic#65514)
  [Uptime] Enable loading on monitor list (elastic#65670)
  ...
@qn895 qn895 deleted the add-job-timing-stats-to-anomaly-jobs branch May 12, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@qn895 qn895

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Job timing stats to the JSON job config
6 participants
@qn895 @elasticmachine @peteharverson @kibanamachine @walterra @alvarezmelissa87