Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix missing apm indicies #53541

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

sorenlouv
Copy link
Member

Closes #52907
Closes #52825

@sorenlouv sorenlouv marked this pull request as ready for review December 23, 2019 10:34
@sorenlouv sorenlouv requested a review from a team as a code owner December 23, 2019 10:34
@sorenlouv sorenlouv force-pushed the ensure-sparse-ui-indices-options branch from 47558a4 to 9883dab Compare December 23, 2019 10:34
@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 Team:APM All issues that need APM UI Team support labels Dec 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #16581 succeeded d2dcddc4146eca9f3a507dad2e8219ba651ca926

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Dec 23, 2019
@sorenlouv sorenlouv merged commit 8b0d5f5 into elastic:master Dec 23, 2019
@sorenlouv sorenlouv deleted the ensure-sparse-ui-indices-options branch December 23, 2019 15:45
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Dec 23, 2019
* [APM] Fix missing apm indicies

* Fix infinite loop in ui indices

* Add test for empty settings
sorenlouv added a commit that referenced this pull request Dec 23, 2019
* [APM] Fix missing apm indicies

* Fix infinite loop in ui indices

* Add test for empty settings
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
…le-saved-objects

* 'master' of github.com:elastic/kibana: (250 commits)
  Allow chromeless applications to render via non-/app routes (elastic#51527)
  Add server rendering service to enable standalone route rendering (elastic#52161)
  Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220)
  Update maps telemetry mappings to account for recent updates (elastic#53803)
  [Maps] Only show legend when layer is visible (elastic#53781)
  remove use of experimental fs.promises api (elastic#53346)
  [APM] Add log statements for flaky test (elastic#53775)
  [APM] Transaction page throws unhandled exception if transactions doesn't have  `http.request` (elastic#53760)
  Licensing plugin functional tests (elastic#53580)
  [Lens] Disable saving visualization until there are no changes to the document (elastic#52982)
  [Monitoring] Added safeguard for some EUI components (elastic#53318)
  [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605)
  Display changed field formats without requiring hard page refresh. (elastic#53746)
  Upgrade EUI to v17.3.1 (elastic#53655)
  [APM] Fix missing apm indicies (elastic#53541)
  Disable inspector for timelion (elastic#53747)
  Clean up search servie (elastic#53701)
  [Dashboard] Grid: removing double handler (elastic#53707)
  Remove SavedObjectRegistryProvider from codebase (elastic#53455)
  Move ui/courier into data shim plugin (elastic#52359)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
* [APM] Fix missing apm indicies

* Fix infinite loop in ui indices

* Add test for empty settings
@dgieselaar dgieselaar self-assigned this Jan 20, 2020
@dgieselaar
Copy link
Member

Tested in Chrome, IE.

@dgieselaar dgieselaar added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] user can set an empty value for UI indices [APM] UI Indices settings page crashes after save/reload
6 participants