Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Detections create prepackage rules #55403

Merged
merged 28 commits into from
Jan 22, 2020
Merged

[SIEM] Detections create prepackage rules #55403

merged 28 commits into from
Jan 22, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jan 21, 2020 •
edited
Loading

Summary

Allow user to load/re-load/update pre-packaged rules from Elastic.

Screen Shot 2020-01-20 at 7 29 50 PM

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM
update extra action on rule detail to match design
512d4fb
@XavierM
remove experimental label
88b3ff6
@XavierM
allow pre-package to be deleted + do not allow wrong user to create p…
6adf429 
…re-packages rules
@XavierM
Additional look back minimum value to 1
3084d05
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
73b85e5 
…ine-cleanup-1
@XavierM
fix flow with edit rule
578bc79
@XavierM
add success toaster when rule is created or updated
d7aa454
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
b9f6ab0 
…ine-cleanup-1
@XavierM
Fix Timeline selector loading
3af5581
@XavierM
review ben doc + change detectin engine to detection even in url
34e7a13
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
2a554e3 
…ine-cleanup-1
@XavierM
Succeeded text size consistency in rule details page
80bba46
@XavierM
fix description of threats
5c34050
@XavierM
fix test
aeddd3f
@XavierM
fix type
d58a473
@XavierM
fix internatinalization
a7c5dbf
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detections-cr…
1ac3af7 
…eate-prepackage-rules
@XavierM
adding pre-packaged rules
593ae78
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detections-cr…
6eb9906 
…eate-prepackage-rules
@XavierM
fix bug + enhance ux
4a885f5
@XavierM
Merge branch 'master' of github.com:elastic/kibana into detections-cr…
9b56050 
…eate-prepackage-rules
@XavierM XavierM self-assigned this Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM mentioned this pull request Jan 21, 2020
Closed
@XavierM XavierM force-pushed the detections-create-prepackage-rules branch from 0ea8d70 to 657521e Compare January 21, 2020 16:24
MichaelMarcialis
MichaelMarcialis reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @XavierM. Leaving a few small comments below.

Also, assuming the "Activity monitor" (or something like "Failure history") tab at the top of the rules page is not being included as part of the initial release, can we add back the border prop to the HeaderPage component? If/when the tabs get introduced on the page, we can remove the prop again.

x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/translations.ts Show resolved Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/index.tsx Outdated Show resolved Hide resolved
...siem/public/pages/detection_engine/rules/components/pre_packaged_rules/load_empty_prompt.tsx Show resolved Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts Show resolved Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts Show resolved Hide resolved
...siem/public/pages/detection_engine/rules/components/pre_packaged_rules/load_empty_prompt.tsx Show resolved Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts Show resolved Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts Show resolved Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts Show resolved Hide resolved
...ns/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/update_callout.tsx Outdated Show resolved Hide resolved
FrankHassanabad
FrankHassanabad approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, gave a quick test spin, LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 5344702 into elastic:master Jan 22, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 22, 2020
@XavierM
[SIEM] Detections create prepackage rules (elastic#55403)
4eab1fd 
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
@XavierM XavierM mentioned this pull request Jan 22, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 22, 2020
@XavierM
[SIEM] Detections create prepackage rules (elastic#55403)
5442cf6 
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
@XavierM XavierM mentioned this pull request Jan 22, 2020
Merged
XavierM added a commit that referenced this pull request Jan 22, 2020
@XavierM
[SIEM] Detections create prepackage rules (#55403) (#55504)
cb5898c 
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
XavierM added a commit that referenced this pull request Jan 22, 2020
@XavierM
[SIEM] Detections create prepackage rules (#55403) (#55503)
bfe9b45 
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 22, 2020
@gmmorris
Merge branch 'master' into pr55026
0dae5de 
* master: (38 commits)
  [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209)
  [SIEM][Detection Engine] Tags being turned into null
  rules part deux (elastic#55507)
  [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357)
  [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488)
  [SIEM] Detections create prepackage rules (elastic#55403)
  [Reporting] Convert CSV Export libs to Typescript (elastic#55117)
  [Maps] show field type icons in data driven styling field select (elastic#55166)
  Adds event log for actions and alerting (elastic#45081)
  [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating
  [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud
  remove incorrect config (elastic#55427)
  Retain pinned filters when loading and clearing saved queries (elastic#54307)
  Resolver zoom, pan, and center controls (elastic#55221)
  Skip failing endpoint saga tests
  [skip-ci] Update migration guide to add rendering service example (elastic#54744)
  [DOCS] Updates to heat map page (elastic#55097)
  [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245)
  [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292)
  [Uptime] Handle locations with names but no geo data (elastic#55234)
  ...
@XavierM XavierM deleted the detections-create-prepackage-rules branch January 22, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 left review comments

@MichaelMarcialis MichaelMarcialis MichaelMarcialis left review comments

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@spong spong Awaiting requested review from spong

Assignees

@XavierM XavierM

Labels
release_note:enhancement Team:SIEM v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @kibanamachine @dhurley14 @FrankHassanabad @MichaelMarcialis