[Logs UI] Use the correct icons and labels in the feature cont… #55292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
release_note:fix
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Zacqary
approved these changes
Jan 21, 2020
weltenwort
changed the title
This was referenced Jan 21, 2020
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Jan 21, 2020
…tic#55292) This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming. fixes elastic#55283
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Jan 21, 2020
…tic#55292) This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming. fixes elastic#55283
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 22, 2020
* master: (38 commits) [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209) [SIEM][Detection Engine] Tags being turned into null rules part deux (elastic#55507) [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357) [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488) [SIEM] Detections create prepackage rules (elastic#55403) [Reporting] Convert CSV Export libs to Typescript (elastic#55117) [Maps] show field type icons in data driven styling field select (elastic#55166) Adds event log for actions and alerting (elastic#45081) [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud remove incorrect config (elastic#55427) Retain pinned filters when loading and clearing saved queries (elastic#54307) Resolver zoom, pan, and center controls (elastic#55221) Skip failing endpoint saga tests [skip-ci] Update migration guide to add rendering service example (elastic#54744) [DOCS] Updates to heat map page (elastic#55097) [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245) [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292) [Uptime] Handle locations with names but no geo data (elastic#55234) ...
weltenwort
added a commit
that referenced
this pull request
Jan 22, 2020
Backports the following commits to 7.x: - [Logs UI] Use the correct icons and labels in the feature cont… (#55292)
weltenwort
added a commit
that referenced
this pull request
Jan 22, 2020
Backports the following commits to 7.6: - [Logs UI] Use the correct icons and labels in the feature cont… (#55292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.
fixes #55283
Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility