[Reporting] Convert CSV Export libs to Typescript #55117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
review
Feature:Reporting
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
commented
Jan 16, 2020
| } | ||
|
|
||
| return val == null ? '' : val.toString(); | ||
| }; |
There was a problem hiding this comment.
There had to be a little bit of changes to this function to support Typescript. The original function was:
export function createEscapeValue(quoteValues) {
return function escapeValue(val) {
if (quoteValues && nonAlphaNumRE.test(val)) {
return `"${val.replace(allDoubleQuoteRE, '""')}"`;
}
return val;
};
}(copied from the deleted file's diff)
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…/kibana into reporting/server-ts-conversion
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
3 tasks
|
@elastic/kibana-security would someone be able to look at the changes to the pre-routing files that were converted to Typescript in this PR? |
joelgriffith
approved these changes
Jan 21, 2020
| import { CSV_JOB_TYPE, PLUGIN_ID } from '../../../common/constants'; | ||
| import { cryptoFactory, LevelLogger } from '../../../server/lib'; | ||
| import { JobDocPayloadDiscoverCsv } from '../types'; | ||
| // @ts-ignore untyped module TODO |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 22, 2020
* [Reporting] Convert CSV Export libs to Typescript * fix jest tests * more ts conversion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
backport: #55510 |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 22, 2020
* master: (38 commits) [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209) [SIEM][Detection Engine] Tags being turned into null rules part deux (elastic#55507) [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357) [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488) [SIEM] Detections create prepackage rules (elastic#55403) [Reporting] Convert CSV Export libs to Typescript (elastic#55117) [Maps] show field type icons in data driven styling field select (elastic#55166) Adds event log for actions and alerting (elastic#45081) [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud remove incorrect config (elastic#55427) Retain pinned filters when loading and clearing saved queries (elastic#54307) Resolver zoom, pan, and center controls (elastic#55221) Skip failing endpoint saga tests [skip-ci] Update migration guide to add rendering service example (elastic#54744) [DOCS] Updates to heat map page (elastic#55097) [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245) [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292) [Uptime] Handle locations with names but no geo data (elastic#55234) ...
tsullivan
added a commit
that referenced
this pull request
Jan 22, 2020
* [Reporting] Convert CSV Export libs to Typescript * fix jest tests * more ts conversion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility