Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky alert details page instances test #57675

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

mikecote
Copy link
Contributor

Skips a test that causes #57426 for now until proper fix comes in.

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 14, 2020
@mikecote mikecote requested a review from a team as a code owner February 14, 2020 12:18
@mikecote mikecote self-assigned this Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit c965a9e into elastic:master Feb 14, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Feb 14, 2020
mikecote added a commit that referenced this pull request Feb 14, 2020
spalger added a commit to spalger/kibana that referenced this pull request Feb 14, 2020
spalger pushed a commit that referenced this pull request Feb 19, 2020
* Revert "Skip flaky test (#57675)"

This reverts commit c965a9e.

* Revert "disable firefox smoke tests so we can fix flakiness out of band"

This reverts commit fe38642.

* Revert "skip flaky tests (#57643)"

This reverts commit b220454.

* Revert "skip flaky suite (#50018)"

This reverts commit b058dc2.

* Revert "skip settings tests (#57608)"

This reverts commit 64625b2.

* Revert "skip failing suite (#44631)"

This reverts commit 8aa718d.

* Revert "skip flaky suite (#44631)"

This reverts commit 6e4efdf.

* Revert "skip flaky test (#57377)"

This reverts commit 59672ab.

* Revert "Skip save query tests (#57589)"

This reverts commit 431a1e9.

* remove hard coded timeouts

* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""

This reverts commit 271f881.

* Revert "remove hard coded timeouts"

This reverts commit 8b843d0.

* wait for managementHome to exist, don't bail early if it's missing

* Revert "skip flaky suite (#45244)"

This reverts commit 0cee1a4.

* extend timeouts for common existsOrFail() calls

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger pushed a commit to spalger/kibana that referenced this pull request Feb 19, 2020
* Revert "Skip flaky test (elastic#57675)"

This reverts commit c965a9e.

* Revert "disable firefox smoke tests so we can fix flakiness out of band"

This reverts commit fe38642.

* Revert "skip flaky tests (elastic#57643)"

This reverts commit b220454.

* Revert "skip flaky suite (elastic#50018)"

This reverts commit b058dc2.

* Revert "skip settings tests (elastic#57608)"

This reverts commit 64625b2.

* Revert "skip failing suite (elastic#44631)"

This reverts commit 8aa718d.

* Revert "skip flaky suite (elastic#44631)"

This reverts commit 6e4efdf.

* Revert "skip flaky test (elastic#57377)"

This reverts commit 59672ab.

* Revert "Skip save query tests (elastic#57589)"

This reverts commit 431a1e9.

* remove hard coded timeouts

* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""

This reverts commit 271f881.

* Revert "remove hard coded timeouts"

This reverts commit 8b843d0.

* wait for managementHome to exist, don't bail early if it's missing

* Revert "skip flaky suite (elastic#45244)"

This reverts commit 0cee1a4.

* extend timeouts for common existsOrFail() calls

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Feb 19, 2020
* Revert "Skip flaky test (#57675)"

This reverts commit c965a9e.

* Revert "disable firefox smoke tests so we can fix flakiness out of band"

This reverts commit fe38642.

* Revert "skip flaky tests (#57643)"

This reverts commit b220454.

* Revert "skip flaky suite (#50018)"

This reverts commit b058dc2.

* Revert "skip settings tests (#57608)"

This reverts commit 64625b2.

* Revert "skip failing suite (#44631)"

This reverts commit 8aa718d.

* Revert "skip flaky suite (#44631)"

This reverts commit 6e4efdf.

* Revert "skip flaky test (#57377)"

This reverts commit 59672ab.

* Revert "Skip save query tests (#57589)"

This reverts commit 431a1e9.

* remove hard coded timeouts

* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""

This reverts commit 271f881.

* Revert "remove hard coded timeouts"

This reverts commit 8b843d0.

* wait for managementHome to exist, don't bail early if it's missing

* Revert "skip flaky suite (#45244)"

This reverts commit 0cee1a4.

* extend timeouts for common existsOrFail() calls

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants