Sets min_doc_count=0 for parent histogram of derivative aggregation #61390
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the docs: The specified metric must be numeric and the enclosing histogram must have min_doc_count set to 0 (default for histogram aggregations). https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation This is now enforced, and currently failing the promotion of the current Elasticsearch build Related to elastic#61387 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
tylersmalley
pushed a commit
that referenced
this pull request
Mar 26, 2020
* chore(NA); bump version to 7.8.0 Also includes cherry-pick of #61390 * Sets min_doc_count=0 for parent histogram of dirivative aggregation Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
I need to merge this in order to unblock the recent ES build and and some downstream teams. So apologies for merging before a review, but if you could please take a look and raise any concerns if there are any. |
|
7.x/7.8: eb5d3ac |
|
Thanks @tylersmalley ❤️ |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 30, 2020
…lastic#61390) From the docs: The specified metric must be numeric and the enclosing histogram must have min_doc_count set to 0 (default for histogram aggregations). https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation This is now enforced, and currently failing the promotion of the current Elasticsearch build Related to elastic#61387 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
Mar 31, 2020
…61390) (#61896) From the docs: The specified metric must be numeric and the enclosing histogram must have min_doc_count set to 0 (default for histogram aggregations). https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation This is now enforced, and currently failing the promotion of the current Elasticsearch build Related to #61387 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the docs:
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation
This is now enforced, and currently failing the promotion of the current Elasticsearch build
Semi-revert of commits tagged in #61366