Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): removes server imports from canvas src plugin #62783

Merged
merged 6 commits into from
Apr 7, 2020
Merged

chore(NA): removes server imports from canvas src plugin #62783

merged 6 commits into from
Apr 7, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 7, 2020

That PR exports the DemoRows enum in a separate file. That file is then imported on public code from the new file instead of the old one demodata/get_demo_rows.ts which prevents the large json files (shirts and ci) being inlined in the public bundle for canvas. That is part of the effort we are taking on #62238

@mistic mistic requested a review from crob611 April 7, 2020 13:37
@mistic mistic requested a review from a team as a code owner April 7, 2020 13:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic added the release_note:skip Skip the PR/issue when compiling release notes label Apr 7, 2020
crob611
crob611 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I was going to do the exact same thing

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 7e3c68b into elastic:master Apr 7, 2020
@mistic
Copy link
Member Author

mistic commented Apr 7, 2020 •
edited
Loading

7.x: 7df3171
7.7: 0e4fba0

@mistic mistic mentioned this pull request Apr 7, 2020
Merged
mistic added a commit to mistic/kibana that referenced this pull request Apr 7, 2020
@mistic
chore(NA): removes server imports from canvas src plugin (elastic#62783)
8af79a3 
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
@mistic mistic mentioned this pull request Apr 7, 2020
Merged
mistic added a commit to mistic/kibana that referenced this pull request Apr 7, 2020
@mistic
chore(NA): removes server imports from canvas src plugin (elastic#62783)
3b11809 
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
mistic added a commit that referenced this pull request Apr 8, 2020
@mistic
chore(NA): removes server imports from canvas src plugin (#62783) (#6…
7df3171 
…2884)

* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
mistic added a commit that referenced this pull request Apr 8, 2020
@mistic
chore(NA): removes server imports from canvas src plugin (#62783) (#6…
0e4fba0 
…2885)

* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
wayneseymour pushed a commit that referenced this pull request Apr 8, 2020
@mistic @wayneseymour
chore(NA): removes server imports from canvas src plugin (#62783)
17d1682 
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @kibanamachine @crob611