[TSVB] Allows the user to change the tooltip mode #67775

stratoula · 2020-05-29T15:11:35Z

Summary

Fixes #60013. We added a dropdown to the panel options of TSVB in order the user to be able to toggle the tooltip mode. So now the user can also see in the tooltip only the values of the selected datapoint.

On the following video we can see the new functionality

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, (https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)

stratoula · 2020-06-01T06:44:09Z

@elasticmachine merge upstream

elasticmachine · 2020-06-01T13:44:17Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula · 2020-06-01T13:45:15Z

We need help on the options of the dropdown menu from a writer.

@KOTungseth can you help me with this?

KOTungseth · 2020-06-03T17:11:26Z

What do you think about changing Tooltip mode to Tooltip?

And for the dropdown, how about:

Show all values
Show single value

stratoula · 2020-06-04T06:36:50Z

@KOTungseth I like it, it is much simpler

cchaos

Screenshots combined with text updates LGTM. 👍 Thanks!

src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js

timroes

We have a validation in place on the serverside, that validates all config sent to it. You need to add the tooltip_mode to the validation schema there, because currently this PR will log to the server console: Request validation error: [panels.0.tooltip_mode]: definition for this key is missing (saved object id: unsaved). This most likely means your TSVB visualization contains outdated configuration. You can report this problem under https://github.com/elastic/kibana/issues/new?template=Bug_report.md

timroes · 2020-06-05T10:20:12Z

src/plugins/vis_type_timeseries/server/routes/post_vis_schema.ts

@@ -247,6 +247,7 @@ export const visPayloadSchema = schema.object({
      series: schema.arrayOf(seriesItems),
      show_grid: numberIntegerRequired,
      show_legend: numberIntegerRequired,
+      tooltip_mode: stringOptionalNullable,


Instead of allowing any string here, could we please make this just specific for the options? schema.maybe(schema.oneOf(['show_all', 'show_focused']))

timroes · 2020-06-08T12:19:58Z

src/plugins/vis_type_timeseries/public/application/components/panel_config/timeseries.js

+      {
+        label: intl.formatMessage({
+          id: 'visTypeTimeseries.timeseries.tooltipOptions.showFocused',
+          defaultMessage: 'Show single value',


Let's please rename this to Show focused values. Show single value does not really make sense, since we not really show only a single value, but if multiple values are close together we still show them all. I have the feeling it's rather confusing naming it "Show single value" and then actually showing multiple values in the tooltip.

timroes

Despite the label change, everything looks good to me. Tested on Firefox & Chrome Linux. Code LGTM. Once label changed and CI is green, feel free to merge

kibanamachine · 2020-06-08T18:40:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 05a7bc4

History

💚 Build #52041 succeeded 073405d
💚 Build #52023 succeeded 341998a
💚 Build #51663 succeeded 0fc0902
💚 Build #51308 succeeded 23a6c86
💚 Build #50743 succeeded fe377df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Allows the user to select the tooltip mode * Fix problem on new TSVB and add new field to schema * Change default value on tooltip dropdown for the focused series option

* master: (37 commits) [DOCS] Adds documentation for drilldowns (elastic#68122) [Telemetry] telemetry.sendUsageFrom: "server" by default (elastic#68071) [ML] Transforms: Support sub-aggregations (elastic#68306) Fixed pre-configured docs link points to the wrong page and functional tests configs (elastic#68606) [Ingest Manager] Update queries from `stream.*` to `dataset.*` (elastic#68322) Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (elastic#68602) Convert Index Templates API routes to snakecase. (elastic#68463) [SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (elastic#68441) [Ingest] OpenAPI spec file (elastic#68323) chore(NA): skip apis Endpoint plugin Endpoint policy api (elastic#68638) bumping makelogs version to v6.0.0 (elastic#66163) [SIEM] Add create template button (elastic#66613) Bump websocket-extensions from 0.1.3 to 0.1.4 (elastic#68414) [ML] Sample data modules - use event.dataset instead of index name (elastic#68538) [ML] Functional tests - fix job validation API test with maxModelMemoryLimit (elastic#68501) [ML] Functional tests - stabilize DFA job creation (elastic#68495) [TSVB] Allows the user to change the tooltip mode (elastic#67775) chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (elastic#68613) chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (elastic#68596) [SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common (elastic#68127) ...

monfera · 2020-09-07T21:05:19Z

Could it be added to the TSVB docs? The current one points to Style but doesn't seem to discuss the contents. See issue above

stratoula force-pushed the add-tooltip-mode-switch branch from 1a54910 to d26a32b Compare May 29, 2020 15:22

stratoula self-assigned this May 29, 2020

stratoula added Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement v8.0.0 v7.9.0 labels May 29, 2020

stratoula marked this pull request as ready for review June 1, 2020 06:43

stratoula requested a review from a team June 1, 2020 06:43

stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 1, 2020

stratoula requested a review from a team June 2, 2020 08:05

stratoula force-pushed the add-tooltip-mode-switch branch 2 times, most recently from 1c236d5 to 23a6c86 Compare June 3, 2020 07:20

stratoula force-pushed the add-tooltip-mode-switch branch from 23a6c86 to 0fc0902 Compare June 4, 2020 07:02

stratoula requested a review from timroes June 4, 2020 08:59

stratoula changed the title ~~[TSVB] Allow the user to change the tooltip mode~~ [TSVB] Allows the user to change the tooltip mode Jun 4, 2020

cchaos approved these changes Jun 4, 2020

View reviewed changes

timroes reviewed Jun 5, 2020

View reviewed changes

src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js Outdated Show resolved Hide resolved

timroes suggested changes Jun 5, 2020

View reviewed changes

timroes reviewed Jun 5, 2020

View reviewed changes

stratoula force-pushed the add-tooltip-mode-switch branch from 341998a to 073405d Compare June 5, 2020 11:26

stratoula requested a review from timroes June 5, 2020 13:22

timroes reviewed Jun 8, 2020

View reviewed changes

timroes approved these changes Jun 8, 2020

View reviewed changes

stratoula added 2 commits June 8, 2020 19:56

Allows the user to select the tooltip mode

49fbbdb

Fix problem on new TSVB and add new field to schema

a435467

Change default value on tooltip dropdown for the focused series option

05a7bc4

stratoula force-pushed the add-tooltip-mode-switch branch from 1c1eac0 to 05a7bc4 Compare June 8, 2020 16:57

stratoula merged commit 88754d2 into elastic:master Jun 9, 2020

stratoula mentioned this pull request Jun 9, 2020

[7.x] [TSVB] Allows the user to change the tooltip mode (#67775) #68622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Allows the user to change the tooltip mode #67775

[TSVB] Allows the user to change the tooltip mode #67775

stratoula commented May 29, 2020 •

edited

Loading

stratoula commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

stratoula commented Jun 1, 2020 •

edited

Loading

KOTungseth commented Jun 3, 2020

stratoula commented Jun 4, 2020

cchaos left a comment

timroes left a comment

timroes Jun 5, 2020 •

edited

Loading

timroes Jun 8, 2020

timroes left a comment

kibanamachine commented Jun 8, 2020

monfera commented Sep 7, 2020

[TSVB] Allows the user to change the tooltip mode #67775

[TSVB] Allows the user to change the tooltip mode #67775

Conversation

stratoula commented May 29, 2020 • edited Loading

Summary

Checklist

stratoula commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

stratoula commented Jun 1, 2020 • edited Loading

KOTungseth commented Jun 3, 2020

stratoula commented Jun 4, 2020

cchaos left a comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

timroes Jun 5, 2020 • edited Loading

Choose a reason for hiding this comment

timroes Jun 8, 2020

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 8, 2020

💚 Build Succeeded

History

monfera commented Sep 7, 2020

stratoula commented May 29, 2020 •

edited

Loading

stratoula commented Jun 1, 2020 •

edited

Loading

timroes Jun 5, 2020 •

edited

Loading