[Security Solution] Fix query fetchPolicy and deduplication #73199

patrykkopycinski · 2020-07-24T14:05:22Z

Summary

This PR introduces queryDeduplication param to the useWithSource to make it possible to apolloClient to differentiate parallel requests from each other and make sure that the cached response from one request was not returned in a different place

Checklist

Unit or functional tests were updated or added to match the most common scenarios

spong · 2020-07-28T03:03:47Z

Checked out, tested locally, and paired with @patrykkopycinski over the changes as well. Was able to confirm the following three fixes:

No more disappearing Alerts Table or failure to load data when the Alerts Histogram is successful
Top-N hover action no longer sometimes fails to load and is displayed as expected
Raw events are still displayed as fixed in [SECURITY] [Timeline] Raw events not displayed #72387 (no regression! 🙌 )

Did a bit of smoke testing and didn't see any fallout from these changes other than the below two items. The extra cancelled query is 🆗 it seems, but if possible we should see if we can keep the Alerts Table in its default loading state as part of this PR (might be an easy fix as seems to only happen on hard refresh, so cache + render state fix?).

@andrew-goldstein & @peluja1012 -- since this changes back to a cache-first policy in some areas if you could desk test this as well the extra 👀 would be appreciated. The queryDeduplication fix for the hooks combined with the cache policy changes seems to be 👍 so far.

Extra cancelled query within Timeline

This should be fine, but just wanted to note the extra cancelled query when within Timeline. This can be seen when switching between event types.

Alerts Table empty container loading state

patrykkopycinski · 2020-07-28T12:07:23Z

@elasticmachine merge upstream

kibanamachine · 2020-07-28T14:22:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d8ca853

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+443.0B	7.3MB

History

💚 Build #64586 succeeded 1539f0b
💚 Build #64522 succeeded 1539f0b
💔 Build #64469 failed de4940d
💚 Build #64174 succeeded 023fbc4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spong · 2020-07-28T15:04:14Z

x-pack/plugins/security_solution/public/detections/components/alerts_table/index.tsx

@@ -433,7 +434,7 @@ export const AlertsTableComponent: React.FC<AlertsTableComponentProps> = ({
    closeAddExceptionModal,
  ]);

-  if (loading || isEmpty(signalsIndex)) {
+  if (loading || indexPatternsLoading || isEmpty(signalsIndex)) {


spong

Checked out the latest and the Alerts Table loading looks good now! Thanks @patrykkopycinski!

This LGTM, but let's wait on one more 👍 for added testing before merging.

elasticmachine · 2020-07-28T15:18:55Z

Pinging @elastic/siem (Team:SIEM)

andrew-goldstein

Thanks for this fix @patrykkopycinski 🙏
Desk tested locally
LGTM 🚀

peluja1012

Pulled down branch and verified that the Exception modal bugs and the empty alerts table bug are no longer there. Looks good! Thank you.

…73199)

@patrykkopycinski

… issues (#73233) ## Summary Fixes the following issues around Risk Score/Severity mapping: * Severity override option cannot be unselected during rule creation * Risk score override option cannot be unselected during rule creation * Cannot fill Critical Severity override at the first attempt * Cannot create a rule with just a Critical severity override Note: When editing rules there is the possibility of the mapping fields remaining `disabled` as they are locked to the 'isLoading' flag from the gql `useFetchIndexPatterns` call, which can sometimes not return/get stuck as loading. @patrykkopycinski has a draft PR to fix this here: #73199 cc @MadameSheema ##### Severity Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497829-b653de00-cf7e-11ea-8e14-c351117b4282.gif" /> Now distinguishes between empty string/value <img width="500" src="https://user-images.githubusercontent.com/2946766/88497776-94f2f200-cf7e-11ea-821e-3766b7bed3dc.png" /> ##### Risk Score Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497842-c075dc80-cf7e-11ea-8c41-606b20a6ac1c.gif" /> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials * Working with @benskelker on API docs. This PR adds `risk_score` (can be `undefined`) to `risk_score.mapping` for future compatibility with mapping to specific risk score values. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

@patrykkopycinski

… issues (elastic#73233) ## Summary Fixes the following issues around Risk Score/Severity mapping: * Severity override option cannot be unselected during rule creation * Risk score override option cannot be unselected during rule creation * Cannot fill Critical Severity override at the first attempt * Cannot create a rule with just a Critical severity override Note: When editing rules there is the possibility of the mapping fields remaining `disabled` as they are locked to the 'isLoading' flag from the gql `useFetchIndexPatterns` call, which can sometimes not return/get stuck as loading. @patrykkopycinski has a draft PR to fix this here: elastic#73199 cc @MadameSheema ##### Severity Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497829-b653de00-cf7e-11ea-8e14-c351117b4282.gif" /> Now distinguishes between empty string/value <img width="500" src="https://user-images.githubusercontent.com/2946766/88497776-94f2f200-cf7e-11ea-821e-3766b7bed3dc.png" /> ##### Risk Score Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497842-c075dc80-cf7e-11ea-8c41-606b20a6ac1c.gif" /> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials * Working with @benskelker on API docs. This PR adds `risk_score` (can be `undefined`) to `risk_score.mapping` for future compatibility with mapping to specific risk score values. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

@patrykkopycinski

… issues (elastic#73233) ## Summary Fixes the following issues around Risk Score/Severity mapping: * Severity override option cannot be unselected during rule creation * Risk score override option cannot be unselected during rule creation * Cannot fill Critical Severity override at the first attempt * Cannot create a rule with just a Critical severity override Note: When editing rules there is the possibility of the mapping fields remaining `disabled` as they are locked to the 'isLoading' flag from the gql `useFetchIndexPatterns` call, which can sometimes not return/get stuck as loading. @patrykkopycinski has a draft PR to fix this here: elastic#73199 cc @MadameSheema ##### Severity Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497829-b653de00-cf7e-11ea-8e14-c351117b4282.gif" /> Now distinguishes between empty string/value <img width="500" src="https://user-images.githubusercontent.com/2946766/88497776-94f2f200-cf7e-11ea-821e-3766b7bed3dc.png" /> ##### Risk Score Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497842-c075dc80-cf7e-11ea-8c41-606b20a6ac1c.gif" /> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials * Working with @benskelker on API docs. This PR adds `risk_score` (can be `undefined`) to `risk_score.mapping` for future compatibility with mapping to specific risk score values. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

@patrykkopycinski

… issues (#73233) (#73543) ## Summary Fixes the following issues around Risk Score/Severity mapping: * Severity override option cannot be unselected during rule creation * Risk score override option cannot be unselected during rule creation * Cannot fill Critical Severity override at the first attempt * Cannot create a rule with just a Critical severity override Note: When editing rules there is the possibility of the mapping fields remaining `disabled` as they are locked to the 'isLoading' flag from the gql `useFetchIndexPatterns` call, which can sometimes not return/get stuck as loading. @patrykkopycinski has a draft PR to fix this here: #73199 cc @MadameSheema ##### Severity Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497829-b653de00-cf7e-11ea-8e14-c351117b4282.gif" /> Now distinguishes between empty string/value <img width="500" src="https://user-images.githubusercontent.com/2946766/88497776-94f2f200-cf7e-11ea-821e-3766b7bed3dc.png" /> ##### Risk Score Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497842-c075dc80-cf7e-11ea-8c41-606b20a6ac1c.gif" /> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials * Working with @benskelker on API docs. This PR adds `risk_score` (can be `undefined`) to `risk_score.mapping` for future compatibility with mapping to specific risk score values. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

…73541) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

@patrykkopycinski

… issues (#73233) (#73542) ## Summary Fixes the following issues around Risk Score/Severity mapping: * Severity override option cannot be unselected during rule creation * Risk score override option cannot be unselected during rule creation * Cannot fill Critical Severity override at the first attempt * Cannot create a rule with just a Critical severity override Note: When editing rules there is the possibility of the mapping fields remaining `disabled` as they are locked to the 'isLoading' flag from the gql `useFetchIndexPatterns` call, which can sometimes not return/get stuck as loading. @patrykkopycinski has a draft PR to fix this here: #73199 cc @MadameSheema ##### Severity Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497829-b653de00-cf7e-11ea-8e14-c351117b4282.gif" /> Now distinguishes between empty string/value <img width="500" src="https://user-images.githubusercontent.com/2946766/88497776-94f2f200-cf7e-11ea-821e-3766b7bed3dc.png" /> ##### Risk Score Mapping Fixes: <img width="500" src="https://user-images.githubusercontent.com/2946766/88497842-c075dc80-cf7e-11ea-8c41-606b20a6ac1c.gif" /> ### Checklist Delete any items that are not applicable to this PR. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials * Working with @benskelker on API docs. This PR adds `risk_score` (can be `undefined`) to `risk_score.mapping` for future compatibility with mapping to specific risk score values. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…73540) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

elasticmachine · 2021-09-23T14:29:18Z

Pinging @elastic/security-solution (Team: SecuritySolution)

Fix query

023fbc4

patrykkopycinski added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 24, 2020

patrykkopycinski added 2 commits July 27, 2020 21:32

cache-first

de4940d

fix tests

5f912af

spong mentioned this pull request Jul 27, 2020

[Security Solution][Detections] Fixes Risk Score and Severity mapping issues #73233

Merged

3 tasks

add info

1539f0b

patrykkopycinski marked this pull request as ready for review July 28, 2020 12:07

patrykkopycinski requested review from a team as code owners July 28, 2020 12:07

elasticmachine and others added 2 commits July 28, 2020 06:07

Merge branch 'master' into fix/use-with-source-cache

db1c057

add loading

d8ca853

spong reviewed Jul 28, 2020

View reviewed changes

spong approved these changes Jul 28, 2020

View reviewed changes

spong added Feature:Detection Rules Anything related to Security Solution's Detection Rules Team:SIEM v7.10.0 labels Jul 28, 2020

andrew-goldstein approved these changes Jul 28, 2020

View reviewed changes

peluja1012 approved these changes Jul 28, 2020

View reviewed changes

patrykkopycinski added bug Fixes for quality problems that affect the customer experience and removed v7.10.0 labels Jul 28, 2020

patrykkopycinski changed the title ~~Fix query~~ [Security Solution] Fix query fetchPolicy and deduplication Jul 28, 2020

patrykkopycinski merged commit 5e62450 into elastic:master Jul 28, 2020

patrykkopycinski deleted the fix/use-with-source-cache branch July 28, 2020 20:13

patrykkopycinski mentioned this pull request Jul 28, 2020

[7.x] [Security Solution] Fix query fetchPolicy and deduplication (#73199) #73540

Merged

patrykkopycinski mentioned this pull request Jul 28, 2020

[7.9] [Security Solution] Fix query fetchPolicy and deduplication (#73199) #73541

Merged

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 28, 2020

[Security Solution] Fix query fetchPolicy and deduplication (elastic#…

78f4b33

…73199)

andrew-goldstein pushed a commit that referenced this pull request Jul 29, 2020

[Security Solution] Fix query fetchPolicy and deduplication (#73199) (#…

8bfe87f

…73541) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

patrykkopycinski added a commit that referenced this pull request Jul 29, 2020

[Security Solution] Fix query fetchPolicy and deduplication (#73199) (#…

152b5b1

…73540) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Fix query fetchPolicy and deduplication #73199

[Security Solution] Fix query fetchPolicy and deduplication #73199

patrykkopycinski commented Jul 24, 2020 •

edited

Loading

spong commented Jul 28, 2020

patrykkopycinski commented Jul 28, 2020

kibanamachine commented Jul 28, 2020

spong Jul 28, 2020

spong left a comment

elasticmachine commented Jul 28, 2020

andrew-goldstein left a comment

peluja1012 left a comment

elasticmachine commented Sep 23, 2021

[Security Solution] Fix query fetchPolicy and deduplication #73199

[Security Solution] Fix query fetchPolicy and deduplication #73199

Conversation

patrykkopycinski commented Jul 24, 2020 • edited Loading

Summary

Checklist

spong commented Jul 28, 2020

Extra cancelled query within Timeline

Alerts Table empty container loading state

patrykkopycinski commented Jul 28, 2020

kibanamachine commented Jul 28, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

spong Jul 28, 2020

Choose a reason for hiding this comment

spong left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 28, 2020

andrew-goldstein left a comment

Choose a reason for hiding this comment

peluja1012 left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 23, 2021

patrykkopycinski commented Jul 24, 2020 •

edited

Loading