Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UiActions][Drilldowns] Fix actions sorting in context menu #77162

Merged
merged 2 commits into from
Sep 14, 2020
Merged

[UiActions][Drilldowns] Fix actions sorting in context menu #77162

merged 2 commits into from
Sep 14, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 10, 2020 •
edited
Loading

Summary

Closes #76923

Before:

Sorting depend on nested triggers chain + order in which actions are registered:

See how "Show on Github" is first because it comes from lower level trigger:

image

After:

Order is based on:

  1. action.order
  2. action.type
  3. action.dispayName

With that we also make sure that for embeddables "Apply filter to current view" is first like it was before:

Screenshot 2020-09-10 at 14 38 26

Checklist

Delete any items that are not applicable to this PR.

@Dosant Dosant added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:UIActions UI actions. These are client side only, not related to the server side actions.. Feature:Drilldowns Embeddable panel Drilldowns v7.10.0 labels Sep 10, 2020
@Dosant Dosant added this to In progress in kibana-app-arch via automation Sep 10, 2020
@Dosant Dosant marked this pull request as ready for review September 10, 2020 14:54
@Dosant Dosant requested a review from a team as a code owner September 10, 2020 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant
Copy link
Contributor Author

Dosant commented Sep 14, 2020

@elasticmachine merge upstream

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Sep 14, 2020
streamich
streamich approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

kibana-app-arch automation moved this from In progress to Review in progress Sep 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
uiActions 170 +136 34

page load bundle size

id value diff baseline
data 1.4MB +10.0B 1.4MB
embeddable 430.7KB +10.0B 430.7KB
uiActions 268.1KB +49.6KB 218.5KB
total +49.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 0fd503e into elastic:master Sep 14, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release Sep 14, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Sep 14, 2020
@Dosant @elasticmachine
[UiActions][Drilldowns] Fix actions sorting in context menu (elastic#…
eca37d4 
…77162)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Dosant Dosant mentioned this pull request Sep 14, 2020
Merged
Dosant added a commit that referenced this pull request Sep 14, 2020
@Dosant @elasticmachine
[UiActions][Drilldowns] Fix actions sorting in context menu (#77162) (#…
b965c21 
…77315)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 14, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
a0fa54e 
* master: (26 commits)
  updating datatable type (elastic#77320)
  [ML] Fix custom URLs processing for security app (elastic#76957)
  [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747)
  [ML] Transforms: API schemas and integration tests (elastic#75164)
  [Mappings editor] Add support for wildcard field type (elastic#76574)
  [Ingest Manager] Fix flyout instruction selection (elastic#77071)
  [Telemetry Tools] update lodash to 4.17 (elastic#77317)
  [APM] Service inventory redesign (elastic#76744)
  Hide management sections based on cluster/index privileges (elastic#67791)
  [Snapshot Restore] Disable steps when form is invalid (elastic#76540)
  [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824)
  Update apm.ts (elastic#77310)
  [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164)
  [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986)
  [APM] API Snapshot Testing (elastic#77229)
  [ML] Functional tests - increase wait time for DFA start (elastic#77307)
  [UiActions][Drilldowns] Fix actions sorting in context menu (elastic#77162)
  [Drilldowns] Wire up new links to new docs (elastic#77154)
  Fix APM issue template
  [Ingest Pipelines] Drop into an empty tree (elastic#76885)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UiActions][Drilldowns] Actions sorting in context menu
4 participants
@Dosant @elasticmachine @kibanamachine @streamich