Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share tslib across bundles #79915

Merged
merged 1 commit into from
Oct 7, 2020
Merged

share tslib across bundles #79915

merged 1 commit into from
Oct 7, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 7, 2020

tslib is used in just about every bundle, and is bound by our TypeScript version (which is already global), so there's no reason to duplicate it everywhere.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 7, 2020
@spalger spalger requested a review from a team as a code owner October 7, 2020 20:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
apm 1272 1271 -1
console 172 170 -2
core 441 440 -1
expressions 107 105 -2
globalSearchBar 23 21 -2
home 208 207 -1
infra 1147 1142 -5
ingestManager 549 548 -1
kibanaReact 307 306 -1
kibanaUtils 193 192 -1
lens 564 563 -1
logstash 190 189 -1
ml 1220 1218 -2
searchprofiler 87 85 -2
securitySolution 2043 2038 -5
transform 339 337 -2
triggersActionsUi 285 283 -2
uptime 657 656 -1
visDefaultEditor 239 238 -1
visualize 207 206 -1
watcher 237 236 -1
total -36

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.js 4.7MB 4.7MB +47.0B

async chunks size

id before after diff
apm 4.2MB 4.1MB -9.5KB
console 1.1MB 1.0MB -10.0KB
home 404.2KB 394.7KB -9.5KB
infra 3.8MB 3.8MB -47.6KB
ingestManager 1.3MB 1.2MB -9.5KB
kibanaReact 358.4KB 358.8KB +328.0B
lens 1.1MB 1.0MB -9.5KB
logstash 213.4KB 203.9KB -9.5KB
ml 11.3MB 11.2MB -39.1KB
searchprofiler 705.1KB 695.1KB -10.0KB
securitySolution 10.5MB 10.5MB -47.6KB
transform 1.2MB 1.2MB -19.4KB
triggersActionsUi 1.5MB 1.5MB -10.0KB
uptime 1.7MB 1.7MB -9.5KB
visDefaultEditor 409.7KB 400.2KB -9.5KB
visualize 273.7KB 264.2KB -9.5KB
watcher 1.0MB 1.0MB -9.9KB
total -269.2KB

page load bundle size

id before after diff
apm 48.2KB 48.3KB +65.0B
console 30.4KB 30.4KB +65.0B
core 661.2KB 651.8KB -9.4KB
expressions 204.2KB 194.6KB -9.6KB
globalSearchBar 46.8KB 37.2KB -9.6KB
home 26.0KB 26.1KB +65.0B
infra 178.6KB 178.7KB +65.0B
ingestManager 391.4KB 391.5KB +65.0B
kibanaReact 143.5KB 133.9KB -9.6KB
kibanaUtils 179.5KB 170.1KB -9.4KB
lens 79.7KB 79.8KB +65.0B
logstash 37.6KB 37.7KB +65.0B
ml 65.6KB 65.7KB +65.0B
searchprofiler 50.9KB 50.9KB +65.0B
securitySolution 593.2KB 593.2KB +65.0B
transform 25.4KB 25.5KB +65.0B
triggersActionsUi 151.4KB 151.4KB +65.0B
uptime 25.2KB 25.3KB +65.0B
visDefaultEditor 34.4KB 34.4KB +65.0B
visualize 41.4KB 41.5KB +65.0B
watcher 27.9KB 28.0KB +65.0B
total -46.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 8f41c59 into elastic:master Oct 7, 2020
@spalger spalger deleted the share-tslib branch October 7, 2020 21:47
spalger added a commit to spalger/kibana that referenced this pull request Oct 7, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit to spalger/kibana that referenced this pull request Oct 7, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Oct 7, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Oct 7, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 8, 2020
* master: (217 commits)
  Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837)
  fix can't edit a scripted field with special char (elastic#79842)
  [ML] clear selection action (elastic#79834)
  [TSVB] Show tooltip on external pointer events (elastic#77306)
  Fixes bug where the same index was being passed in (elastic#79949)
  Adds date time query and return fields for timestamps and overrides (elastic#79911)
  [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920)
  add the correct class to truncate the names (elastic#79921)
  [kbn/optimizer] report limits with ci metrics (elastic#78205)
  [release notes] extract "dev docs" comment too (elastic#79351)
  Revert "skips test failing promotion (elastic#79777)" (elastic#79904)
  share tslib across bundles (elastic#79915)
  remove entire suite as partial skips aren't doing the trick
  skip flaky suite (elastic#78689)
  Skip failing suite (elastic#79522)
  skip flaky suite (elastic#79910)
  [es/mappings] remove doc_values from text fields (elastic#79869)
  remove skipped snapshots
  skip flaky tests (elastic#79891)
  chore(NA): add missing branches into backportrc configuration file (elastic#79848)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants