Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip flaky test #80670

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 15, 2020

Summary

Unskipping a flaky test in Discover after 2x100 flaky test runner tests, speeding up the test a bit by setting time range via ui settings.

Running it isolated:

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/908/testReport/Chrome%20UI%20Functional%20Tests/

Running the whole cgroup6

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/909/testReport/Chrome%20UI%20Functional%20Tests/

So this test should be innocent until proven guilty (There might be some underlying problem though, but unrelated to the test).

Fixes #78689

Checklist

@kertal kertal self-assigned this Oct 16, 2020
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Discover Discover Application labels Oct 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal added v8.0.0 v7.11.0 v7.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 16, 2020
@kertal kertal marked this pull request as ready for review October 16, 2020 13:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested a review from spalger October 16, 2020 13:46
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal kertal merged commit 898e21f into elastic:master Oct 16, 2020
kertal added a commit to kertal/kibana that referenced this pull request Oct 16, 2020
kertal added a commit to kertal/kibana that referenced this pull request Oct 16, 2020
kertal added a commit that referenced this pull request Oct 16, 2020
kertal added a commit that referenced this pull request Oct 16, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
* master: (51 commits)
  [Discover] Unskip flaky test (elastic#80670)
  Fix security solution template label (elastic#80754)
  [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721)
  Moving loader to logo in header, add a slight 250ms pause (elastic#78879)
  [Security Solution][Cases] Fix bug with case connectors (elastic#80642)
  Update known-plugins.asciidoc (elastic#75388)
  [Lens] Add median operation (elastic#79453)
  Fix navigateToApp logic when navigating to the current app. (elastic#80809)
  [Visualizations] Fix bad color mapping with multiple split series (elastic#80801)
  [ILM] Add esErrorHandler for the new es js client (elastic#80302)
  Fix codeowners (elastic#80826)
  skip flaky suite (elastic#79463)
  [Timelion] Remove kui usage (elastic#80287)
  [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779)
  [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579)
  Allow the default space to be accessed via `/s/default` (elastic#77109)
  Add script to identify plugin dependencies for TS project references migration (elastic#80463)
  [Search] Client side session service (elastic#76889)
  feat: 🎸 add separator for different context menu groups (elastic#80498)
  Lazy load reporting (elastic#80492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0
Projects
None yet
4 participants