[O11y Overview] Add code to display/hide UX section when appropriate #80873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
added
the
release_note:skip
justinkambic
force-pushed
the
overview_display-empty-ux-section
branch
from
e5065f3
to
4c6ff3d
Compare
shahzad31
reviewed
Oct 20, 2020
| @@ -64,7 +64,8 @@ export function DataSections({ bucketSize, hasData, absoluteTime, relativeTime } | |||
| /> | |||
| </EuiFlexItem> | |||
| )} | |||
| {hasData?.ux && ( | |||
| {/* @ts-ignore see https://github.com/elastic/kibana/issues/81081 */} | |||
| {hasData?.ux?.hasData && ( | |||
There was a problem hiding this comment.
instead of changing the api or suppressing the type , i feel like we can improve the types here. if you notice two lines below it's also (hasData.ux as UXHasDataResponse).serviceName as string used like that.
there is actually already a type declared to handle this specific api use case https://github.com/elastic/kibana/blob/master/x-pack/plugins/observability/public/typings/fetch_overview_data/index.ts#L40
need to check why it's not working.
There was a problem hiding this comment.
Great suggestion!
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 21, 2020
…lastic#80873) * Add code to display/hide UX section when appropriate. * Suppress errors with link to dedicated issue. * Fix typo in call to action. * Remove type error suppression.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 21, 2020
…lastic#80873) * Add code to display/hide UX section when appropriate. * Suppress errors with link to dedicated issue. * Fix typo in call to action. * Remove type error suppression.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #80197.
Resolves #81081.
It was noted that a preview is shown for the UX dashboard even when no data is present, rather than the call to action that is appropriate.
The cause is a bug that doesn't look for the appropriate field. The UX app has a
hasDataflag that is absent from the other apps in the API response. The correct solution to this problem is updating the API to return the correct value, but I felt as a fix for this bug for 7.10.0 this would be less obtrusive.We should track this and update the API in 7.11.0 to make UX status follow the same interface as the rest of the o11y apps so we don't have special handling code like this.
NOTE: I created a follow-up issue to track these error suppressions, we should follow-up with a 7.11.0 PR to fix the API.
Checklist
Delete any items that are not applicable to this PR.
For maintainers