Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Fix map color variance and apply proper filter for extended stats #81106

Merged
merged 6 commits into from
Oct 21, 2020
Merged

[UX] Fix map color variance and apply proper filter for extended stats #81106

merged 6 commits into from
Oct 21, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 20, 2020 •
edited
Loading

Summary

Fixes: #81208

Tested against data from dev-next-oblt cluster against different time ranges.

Before:
image

After:
For last 24 hours period on dev-next

image

@shahzad31 shahzad31 mentioned this pull request Oct 20, 2020
Closed
@shahzad31 shahzad31 changed the title Fix map [UX] Fix map color variance and apply proper filter for extended stats Oct 21, 2020
@shahzad31 shahzad31 marked this pull request as ready for review October 21, 2020 08:09
@shahzad31 shahzad31 requested a review from a team as a code owner October 21, 2020 08:09
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0 labels Oct 21, 2020
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic
justinkambic approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and confirmed that the same data that caused an all-blue map on master resulted in one that was highlighted more as I'd expect.

LGTM

@andrewvc andrewvc merged commit ab8bf78 into elastic:master Oct 21, 2020
andrewvc pushed a commit to andrewvc/kibana that referenced this pull request Oct 21, 2020
@shahzad31 @andrewvc
[UX] Fix map color variance and apply proper filter for extended stats (
53b208e 
elastic#81106)

Fixes: elastic#81208 correctly coloring the UX map
@andrewvc andrewvc mentioned this pull request Oct 21, 2020
Merged
andrewvc pushed a commit to andrewvc/kibana that referenced this pull request Oct 21, 2020
@shahzad31 @andrewvc
[UX] Fix map color variance and apply proper filter for extended stats (
833d615 
elastic#81106)

Fixes: elastic#81208 correctly coloring the UX map
@andrewvc andrewvc mentioned this pull request Oct 21, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 21, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-w…
805a55d 
…arm-phase-to-formlib

* 'master' of github.com:elastic/kibana: (55 commits)
  [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106)
  [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082)
  [DOCS] Add link for monitoring ssl settings (elastic#81057)
  [test] Await loading indicator in monitoring test (elastic#81279)
  [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512)
  [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287)
  [Discover] Deangularize context.app (elastic#80851)
  [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873)
  [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671)
  Fix tagcloud word overlapping (elastic#81161)
  [Security Solution] Fixes flaky test rules (elastic#81040)
  Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183)
  [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301)
  Add namespaced version of the API call (elastic#81278)
  [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123)
  [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236)
  [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084)
  [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239)
  skip flaky suite (elastic#81264)
  [Maps] fix top-level Map page is called 'Kibana' (elastic#81238)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
@shahzad31 shahzad31 deleted the fix-map branch October 21, 2020 16:20
andrewvc added a commit that referenced this pull request Oct 21, 2020
@andrewvc @shahzad31
[UX] Fix map color variance and apply proper filter for extended stats (
7af2187 
#81106) (#81335)

Fixes: #81208 correctly coloring the UX map

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
andrewvc added a commit that referenced this pull request Oct 22, 2020
@andrewvc @shahzad31
[UX] Fix map color variance and apply proper filter for extended stats (
2278d26 
#81106) (#81333)

Fixes: #81208 correctly coloring the UX map

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [User Experience] Map does not show variance when looking at longer durations
5 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic @andrewvc