Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Experience] Use EuiSelect for percentiles instead of SuperSelect #81082

Merged
merged 5 commits into from
Oct 21, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Oct 19, 2020

Summary

Fixes #81031 by switching from EuiSuperSelect to an EuiSelect for percentile selection

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 19, 2020
@andrewvc andrewvc requested a review from a team as a code owner October 19, 2020 23:02
@andrewvc andrewvc self-assigned this Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@andrewvc andrewvc added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 19, 2020
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and select continues to work. Code LGTM.

Fix type errors/test and WFG

@andrewvc
Copy link
Contributor Author

jenkins, retest this please

(unrelated failing APM test)

@andrewvc
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB -756.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrewvc andrewvc merged commit 64e1723 into elastic:master Oct 21, 2020
@andrewvc andrewvc deleted the standardize-select branch October 21, 2020 14:49
andrewvc added a commit to andrewvc/kibana that referenced this pull request Oct 21, 2020
elastic#81082)

Fixes elastic#81031 by switching from EuiSuperSelect to an EuiSelect for percentile selection
andrewvc added a commit to andrewvc/kibana that referenced this pull request Oct 21, 2020
elastic#81082)

Fixes elastic#81031 by switching from EuiSuperSelect to an EuiSelect for percentile selection
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 21, 2020
…arm-phase-to-formlib

* 'master' of github.com:elastic/kibana: (55 commits)
  [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106)
  [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082)
  [DOCS] Add link for monitoring ssl settings (elastic#81057)
  [test] Await loading indicator in monitoring test (elastic#81279)
  [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512)
  [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287)
  [Discover] Deangularize context.app (elastic#80851)
  [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873)
  [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671)
  Fix tagcloud word overlapping (elastic#81161)
  [Security Solution] Fixes flaky test rules (elastic#81040)
  Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183)
  [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301)
  Add namespaced version of the API call (elastic#81278)
  [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123)
  [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236)
  [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084)
  [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239)
  skip flaky suite (elastic#81264)
  [Maps] fix top-level Map page is called 'Kibana' (elastic#81238)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
andrewvc added a commit that referenced this pull request Oct 21, 2020
#81082) (#81332)

Fixes #81031 by switching from EuiSuperSelect to an EuiSelect for percentile selection
andrewvc added a commit that referenced this pull request Oct 21, 2020
#81082) (#81331)

Fixes #81031 by switching from EuiSuperSelect to an EuiSelect for percentile selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Experience] Percentile selector should use EuiSelect not EuiSuperSelect
4 participants