Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (#81123) #81275

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

… influence legacy format. (elastic#81123)

- Fixes a race condition where searches for data grid results with different parameters would return in different order with the wrong results on display. Fix uses a pattern to cancel useEffect callback for getIndexData().
- Fixes identifying pre 7.10 feature influence format for outlier detection and will display a callout on the results page with information for a workaround.
- To fix identifying the legacy format, some cleanup of other code relating to the old format had to be done. The ml results object field is no longer treated as a "special" field for outlier detection and is treated and retrieved in the same way as other fields.
- Adds an error callout if no Kibana index pattern is available for source/dest index.
@walterra walterra self-assigned this Oct 21, 2020
@walterra walterra added the :ml label Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 7.3MB 7.3MB +6.3KB

distributable file count

id before after diff
oss - 28782 +28782

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson peteharverson merged commit 2c44e24 into elastic:7.x Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants