[Fleet] Fix agent action observable for long polling #81376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
the
release_note:skip
nchaulet
commented
Oct 21, 2020
| @@ -247,11 +247,16 @@ export async function getNewActionsSince( | |||
| nodeTypes.literal.buildNode(false), | |||
| ]) | |||
| ), | |||
| nodeTypes.function.buildNodeWithArgumentNodes('is', [ | |||
There was a problem hiding this comment.
added this condition to not fetch POLICY_CHANGE here, (the action was filtered in the code after) but in my opinion the earlier we filter it the better it is
nchaulet
force-pushed
the
fix-agent-action-long-polling
branch
from
b177026
to
12f99ce
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jen-huang
approved these changes
Oct 21, 2020
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Oct 22, 2020
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Oct 22, 2020
nchaulet
added a commit
that referenced
this pull request
Oct 22, 2020
nchaulet
added a commit
that referenced
this pull request
Oct 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 22, 2020
* master: (63 commits) [KP] Fix Headers timeout issue (elastic#81140) [ML] Functional tests - stabilize typing with checks service method (elastic#81338) tabify - support docs (elastic#80351) [Security Solution][Detections] Look-back time logic fix (elastic#81383) [Workplace Search] Add top-level tests for Groups (elastic#81215) [Fleet] Fix agent action observable for long polling (elastic#81376) [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373) skip flaky suite (elastic#78689) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357) Ensure some data is returned (elastic#81375) Change dumb-init to tini (elastic#81126) [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242) Use Storybook Controls instead of Knobs (elastic#80705) [junit] make sure that report paths are unique (elastic#81255) bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288) run ssl tests on CI (elastic#81320) Fix alert defaults (elastic#81207) [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078) Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657) [Monitoring] Use async/await (elastic#81200) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolve #80930
The policy reassign is relying on fetching
INTERNAL_POLICY_REASSIGNaction, but looks like there is some race condition that can cause the action to not been fetched.This PR fix it and add some unit test.
Details
switchMapto anexhaustMapso if the functiongetNewActionsSincetake more than 5 seconds we do not loose actions.getNewActionsSinceinstead of the last time we fetched data, as it's looks like thecreated_atdate will be available to search in elastic after the document is created in Kibana