[backport] PR #7920,#8313 to 4.6 - Upgrade to Node 6.4.0 #8213
Conversation
|
Discovered a deprecation warning when used with Shield: |
|
I just saw this a few minutes ago. It's happening in master as well. |
|
#8313 resolves the deprecation warning. Once that is merged, I will backport to 4.6 then continue with this PR. |
tylersmalley
force-pushed
the
4.6-node6
branch
from
efbf48a
to
95712a3
Compare
* Updated dependencies to include graceful-fs ~4.0 * Replaced deprecated grunt-s3 package with suggested grunt-aws-s3 * Update licenses task to better support npm 3 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
4.6-node6
branch
from
8a2aa76
to
fa249ce
Compare
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
4.6-node6
branch
from
fa249ce
to
f1263fe
Compare
tylersmalley
changed the title
|
This PR now includes the backport of #8313 as both needed manual intervention and should happen at the same time anyways. |
|
We should definitely do thorough review/testing on this before we click merge. I wouldn't want any important bug fixes not to be able to go out while we verify that this is good to go. |
|
LGTM I tested this on Kibana and with the Security plugin, no issues as far as I can tell. |
There was a problem hiding this comment.
After some guidance for setting this up properly, everything appears to be working as expected. I do see many "Error: read ECONNRESET
at exports._errnoException (util.js:1026:11)
at TLSWrap.onread (net.js:563:26)
"
errors, but as discussed offline, that will be filed as a separate issue. Doesn't seem to affect usage.
|
In my long-running testing I ran into an error which ultimately stalled the server: Holding off on merging for now. |
|
The error ended up being caused by performing a request to http when https was enabled, something which is also present in 4.6 and not introduced in this PR. The server was not stalled, but rather the request did not immediately fail. Discussed with @spalger to confirm it's not a show-stopper for this PR. |
|
Spoke with @epixa and we are merging this to begin testing on the snapshot. There is still discussion on if this warrants a 4.7 release or not. |
Backport PR #7920
Upgrade to Node 6.4.0
Backport PR #8313
Commit 1:
Upgrades Hapi to 14.2.0
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0.
Node deprecation: nodejs/node@8e8959d
Iron's resolution: hapijs/iron@9e0a1ef
As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682
Signed-off-by: Tyler Smalley tyler.smalley@elastic.co