[Uptime] simple monitor status alert fix for page duty and other connectors #87460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
changed the title
|
@elasticmachine merge upstream |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
justinkambic
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
LGTM - everything seems to be working ok. Had a few questions about the future of the code we're adding here.
Smoke testing process
- I created connectors for PagerDuty, ServiceNow, Slack, and an extra server log connector to use for control purposes.
- I defined a local monitor that was up, and allowed data to accumulate.
- I killed the process that was running and waited for the alert to fire
Slack:
Server log:
PagerDuty:
ServiceNow: I must have misconfigured something. I got an error like:server log [13:48:19.750] [warning][actions][actions][plugins] action execution failure: .servicenow:01f234e0-5505-11eb-ab10-f71ddcabade6: service-now: an error occurred while running the action executor: [Action][ServiceNow]: Unable to create incident. Error: Request failed with status code 401 - I attempted to create a new user in ServiceNow.
- I re-started my service to resolve the current alert instance, and then stopped the service once more.
- After re-configuring the ServiceNow connector and testing it in the management portal, it was a "successful" run:
| TeamsActionTypeId, | ||
| WebhookActionTypeId, | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| } from '../../../../actions/server/builtin_action_types'; |
There was a problem hiding this comment.
Could we maybe ask Alerting to export these in the future to avoid busting the linter?
There was a problem hiding this comment.
yeah another idea was to make an an uptime endpoint for this.
| incident: { | ||
| short_description: MonitorStatusTranslations.defaultActionMessage, | ||
| description: MonitorStatusTranslations.defaultActionMessage, | ||
| impact: '2', |
There was a problem hiding this comment.
Should we plan to make these fields configurable for this, Jira, PagerDuty, etc?
There was a problem hiding this comment.
yeah make sense, let's follow up on this.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jan 14, 2021
…ectors (elastic#87460) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jan 14, 2021
…ectors (elastic#87460) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #84459
This PR makes sure, that auto generated alert by one click uses correct params for each connectors.
Params validity is made sure by type checking.
Testing:
To test this PR, you will need to create a trial page duty and service now accounts and make sure alert works with those connectors.
After adding connectors, add those in uptime settings for default connectors. And then try creating alert from monitor list for few monitors and see if it get's triggered for down time.
Connect me if you want to test those connectors, i can provide my credentials for those connectors.
Note: i wanted to write functional tests but it turns out mocking them isn't that simple, considiring limited time frame, i have created a follow up issue
elastic/uptime#279