Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates ingest_pipelines to a TS project ref #89505

Merged
merged 12 commits into from
Feb 1, 2021
Merged

Migrates ingest_pipelines to a TS project ref #89505

merged 12 commits into from
Feb 1, 2021

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jan 27, 2021 •
edited
Loading

Summary

Partially addresses #89321

tsc compiler performance with running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit

** Before
Files: 16921
Lines: 1861400

** After
Files: 16453
Lines: 1837304

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 27, 2021
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner January 27, 2021 22:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@TinaHeiligers TinaHeiligers marked this pull request as draft January 27, 2021 23:23
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@sebelga
Copy link
Contributor

sebelga commented Jan 28, 2021

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elastic/es-ui I'm getting weird CI failures that I haven't seen before and need your help with please 🙏 . e.g.:

info [  kibana  ] Checking Windows for paths > 200 characters
02:58:11     │ERROR failure 3 sec
02:58:11     │ERROR Error: Windows has a path limit of 260 characters so we limit the length of paths in Kibana to 200 characters  and the following files exceed this limit:
02:58:11     │       - x-pack/plugins/ingest_pipelines/target/types/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item_tooltip/pipeline_processors_editor_item_tooltip.d.ts.map

@TinaHeiligers TinaHeiligers mentioned this pull request Jan 28, 2021
Closed
@cjcenizal cjcenizal mentioned this pull request Jan 28, 2021
Merged
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@TinaHeiligers TinaHeiligers mentioned this pull request Jan 29, 2021
Closed
@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 30, 2021 00:16
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner January 30, 2021 00:16
@TinaHeiligers TinaHeiligers force-pushed the ts-project-refs-es_ui/ingest_pipelines branch from 92067c4 to 8ffe874 Compare January 31, 2021 16:05
sebelga
sebelga approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @TinaHeiligers !

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 723.3KB 723.3KB -20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 9787911 into elastic:master Feb 1, 2021
@TinaHeiligers TinaHeiligers deleted the ts-project-refs-es_ui/ingest_pipelines branch February 1, 2021 17:26
@TinaHeiligers TinaHeiligers mentioned this pull request Feb 1, 2021
Merged
TinaHeiligers added a commit that referenced this pull request Feb 1, 2021
@TinaHeiligers @kibanamachine
[7.x] Migrates ingest_pipelines to a TS project ref (#89505) (#89897)
f845e19 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TinaHeiligers @elasticmachine @sebelga @kibanamachine @ryankeairns