-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate indexPatternManagement to TS project ref #89759
Merged
TinaHeiligers
merged 4 commits into
elastic:master
from
TinaHeiligers:ts-project-refs/index_pattern_management
Feb 1, 2021
Merged
Migrate indexPatternManagement to TS project ref #89759
TinaHeiligers
merged 4 commits into
elastic:master
from
TinaHeiligers:ts-project-refs/index_pattern_management
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
chore
v8.0.0
Team:AppServices
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
labels
Jan 29, 2021
TinaHeiligers
changed the title
Adds tsconfig.json to index_pattern_management
Migrate indexPatternManagement to TS project ref
Jan 29, 2021
Pinging @elastic/kibana-app-services (Team:AppServices) |
cc @elastic/kibana-app-services |
This was referenced Jan 30, 2021
mattkime
approved these changes
Feb 1, 2021
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime overview alert popover controlsStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #80508 (App services section)
tsc compiler performance with running
node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit
** Before
Files: 3044
Lines: 336735
** After
Files: 2574
Lines: 315345