Rename alerts plugin to alerting #92898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
spalger
approved these changes
Mar 3, 2021
|
Pinging @elastic/apm-ui (Team:apm) |
mikecote
added
the
auto-backport
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Mar 4, 2021
dhurley14
approved these changes
Mar 4, 2021
sorenlouv
approved these changes
Mar 4, 2021
…nto alerting/rename-plugin
pmuellr
approved these changes
Mar 5, 2021
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @mikecote |
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Mar 5, 2021
* Rename alerts plugin to alerting * Deprecate old config values * Few more renames * Update plugin list * Rename xpack.alerts -> xpack.alerting * Fix some ESLint rules * Fix typecheck * Fix some test failures * Some more renames * Fix ESLint * Fix some test failures * Fix failing jest test * Undo exclusive test * Fix APM deps * Fix docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # api_docs/alerting.json # api_docs/triggers_actions_ui.json # rfcs/text/0003_handler_interface.md
mikecote
added a commit
that referenced
this pull request
Mar 6, 2021
* Rename alerts plugin to alerting * Deprecate old config values * Few more renames * Update plugin list * Rename xpack.alerts -> xpack.alerting * Fix some ESLint rules * Fix typecheck * Fix some test failures * Some more renames * Fix ESLint * Fix some test failures * Fix failing jest test * Undo exclusive test * Fix APM deps * Fix docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # .github/CODEOWNERS # api_docs/alerting.json # api_docs/triggers_actions_ui.json # rfcs/text/0003_handler_interface.md Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 9, 2021
In elastic#92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it.
smith
added a commit
that referenced
this pull request
Mar 10, 2021
In #92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2021
In elastic#92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it.
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2021
In #92898 the `alerts` plugin was renamed to `alerting`. We were checking if this plugin is enabled with a check like `'alerts' in plugins`, which is not type checked. Change the check to use `!!plugins.alerting` so this type of change will be caught in the future. Rename `get_alert_capabilities` to `get_alerting_capabilities` to match the name of the exported function. Add a test for it. Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #90377.
Renames
alertsplugin toalerting.