Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] Fix links to the numeral formatting (#94858) #94954

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Mar 18, 2021

Backports the following commits to 7.12:

* Fix links to the numeral formatting in the advanced settings (elastic#84167)
* Fix a link to the numeral formatting in the index pattern field settings (elastic#84167)
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
#	src/core/public/doc_links/doc_links_service.ts
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/__snapshots__/number.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/number.tsx
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/__snapshots__/percent.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/percent.test.tsx
@dokmic dokmic enabled auto-merge (squash) March 18, 2021 17:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 477.6KB 477.7KB +95.0B
indexPatternManagement 69.8KB 70.1KB +260.0B
total +355.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit 37dfe5f into elastic:7.12 Mar 18, 2021
@dokmic dokmic deleted the backport/7.12/pr-94858 branch March 22, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants