change config reload message #98455
Merged
change config reload message #98455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
Bamieh
reviewed
Apr 27, 2021
src/core/server/bootstrap.ts
Outdated
| @@ -61,15 +61,15 @@ export async function bootstrap({ configs, cliArgs, applyConfigOverrides }: Boot | |||
|
|
|||
| function reloadLoggingConfig() { | |||
There was a problem hiding this comment.
maybe the name of the function should be changed too?
There was a problem hiding this comment.
That would make sense, yea 😅
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 28, 2021
* change config reload message * change function name
pgayvallet
added a commit
that referenced
this pull request
Apr 28, 2021
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
May 11, 2021
* change config reload message * change function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #52756
Change the log message used when config reloads due to SIGHUP