Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about using Filebeat modules with Logstash #10438

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Feb 13, 2019

Adds docs that show how to load ingest pipelines and use them with Filebeat modules. I think some users may want to define their own configurations in LS, so I've kept the configuration examples (and tested them).

Sorry...no link to a review copy of the built docs because firebase is not playing nice. :-/

This PR addresses a few open issues in the Beats docs. I've added the fix to the existing LS docs since we already have a section there about using Filebeat modules with Logstash.

elastic/beats#9037
elastic/beats#6280

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement. Nice Kafka example. I did not test it, but will flag it for later.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these docs, they will be really helpful.

It LGTM once Andrew's comment is addressed.

docs/static/fb-ls-kafka-example.asciidoc Outdated Show resolved Hide resolved
docs/static/filebeat-modules.asciidoc Show resolved Hide resolved
@dedemorton dedemorton merged commit d8c7a98 into elastic:master Feb 15, 2019
dedemorton added a commit to dedemorton/logstash that referenced this pull request Feb 15, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review
dedemorton added a commit to dedemorton/logstash that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review
dedemorton added a commit to dedemorton/logstash that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review
dedemorton added a commit to dedemorton/logstash that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review
elasticsearch-bot pushed a commit that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review

Fixes #10481
elasticsearch-bot pushed a commit that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review

Fixes #10481
elasticsearch-bot pushed a commit that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review

Fixes #10482
elasticsearch-bot pushed a commit that referenced this pull request Feb 20, 2019
* Improve docs about using Filebeat modules with Logstash

* Add fixes from review

Fixes #10482
@dedemorton dedemorton deleted the issue#9095 branch February 20, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants