Fix issue setting 'enable_metric => false' on a plugin #10538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics.
jsvd
approved these changes
Mar 13, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes #10538
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes #10538
|
@robbavey can you create a backport of this to 6.7 since it doesn't merge cleanly? |
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes elastic#10538
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes elastic#10538
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes elastic#10538
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit fixes a ClassCastException which happens when a plugin has the `enable_metric` setting set to false - a NullMetricExt is assumed, but that is only created when 'metric.collect' is set to 'false' in the Logstash configuration, not when an individual plugin disables its metrics. Fixes #10538 Fixes #10553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a ClassCastException which happens when
a plugin has the
enable_metricsetting set to false - aNullMetricExt is assumed, but that is only created when
'metric.collect' is set to 'false' in the Logstash configuration,
not when an individual plugin disables its metrics.