Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONTHDAY must not require a leading zero for day-of-month < 10 #1353

Closed
wants to merge 2 commits into from
Closed

MONTHDAY must not require a leading zero for day-of-month < 10 #1353

wants to merge 2 commits into from

Conversation

kanarip
Copy link

@kanarip kanarip commented May 9, 2014

@colinsurprenant
Copy link
Contributor

Thanks for your contribution. It looks ok but its hard to validate, regexp can be tricky. Ideally I'd really like to see specs for this in spec/filter/grok.rb (obviously, specs that do not pass without the fix). Let us know if your need help writing specs.

@colinsurprenant colinsurprenant added this to the v1.4.2 milestone May 10, 2014
@kanarip
Copy link
Author

kanarip commented May 30, 2014

I've added some tests based on the real-life patterns I'm working with.

@jordansissel jordansissel modified the milestones: 1.4.3, v1.4.2 Jun 17, 2014
@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@jordansissel jordansissel modified the milestones: v1.5.0, 1.4.3 Nov 4, 2014
@jsvd
Copy link
Member

jsvd commented Nov 21, 2014

@kanarip since we're moving the plugins to separate repositories, would you mind reopening this PR in https://github.com/logstash-plugins/logstash-patterns-core?

Also, can you do step 2 of the contributing guide? Thanks!

@jordansissel jordansissel added O(1) and removed O(1) labels Dec 17, 2014
@suyograo
Copy link
Contributor

suyograo commented Jan 7, 2015

@kanarip thanks for the tests. Can you please do step 2 of the contributing guide here -- https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps

@jsvd jsvd mentioned this pull request Jan 7, 2015
Closed
@jsvd
Copy link
Member

jsvd commented Jan 7, 2015

@kanarip I moved your patches to logstash-plugins/logstash-patterns-core#5

@jsvd
Copy link
Member

jsvd commented Jan 16, 2015

closing as dup for logstash-plugins/logstash-patterns-core#5

@jsvd jsvd closed this Jan 16, 2015
@purbon purbon mentioned this pull request Sep 7, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement missing cla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kanarip @colinsurprenant @elasticsearch-release @jsvd @suyograo @jordansissel