Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #14499 to 8.4: drop support for all DES ciphers and simplify cipher list #14501

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2022

Backport PR #14499 to 8.4 branch, original message:


Remove support for DES-CBC3-SHA https://ciphersuite.info/cs/TLS_RSA_WITH_3DES_EDE_CBC_SHA/

Also unnecessary exclusions for EDH-DSS-DES-CBC3-SHA, EDH-RSA-DES-CBC3-SHA and KRB5-DES-CBC3-SHA since there's already a "!DES" rule.

Before:

❯ bin/logstash -i irb                                                            
[2022-09-07T10:53:12,781][INFO ][logstash.runner          ] Log4j configuration path used is: /Users/joaoduarte/elastic/logstash/config/log4j2.properties
[2022-09-07T10:53:12,786][INFO ][logstash.runner          ] Starting Logstash {"logstash.version"=>"8.5.0", "jruby.version"=>"jruby 9.3.7.0 (2.6.8) 2022-08-16 c79ef237e0 OpenJDK 64-Bit Server VM 17.0.4.1+1 on 17.0.4.1+1 +indy +jit [arm64-darwin]"}
irb(main):001:0> pp OpenSSL::SSL::SSLContext.new.ciphers.map {|c| c.first }.grep /DES/
["DES-CBC3-SHA"]
=> ["DES-CBC3-SHA"]

After:

~/elastic/logstash harden_ssl_ciphers_remove_3des*
❯ git co e6ecfcec7 ./logstash-core/lib/logstash/patches/stronger_openssl_defaults.rb
Updated 1 path from d052c6b0a

~/elastic/logstash harden_ssl_ciphers_remove_3des*
❯ bin/logstash -i irb                                                               
[2022-09-07T10:53:49,432][INFO ][logstash.runner          ] Starting Logstash {"logstash.version"=>"8.5.0", "jruby.version"=>"jruby 9.3.7.0 (2.6.8) 2022-08-16 c79ef237e0 OpenJDK 64-Bit Server VM 17.0.4.1+1 on 17.0.4.1+1 +indy +jit [arm64-darwin]"}
irb(main):001:0> pp OpenSSL::SSL::SSLContext.new.ciphers.map {|c| c.first }.grep /DES/
[]
=> []

…14499)

Remove support for DES-CBC3-SHA.

Also removes unnecessary exclusions for EDH-DSS-DES-CBC3-SHA, EDH-RSA-DES-CBC3-SHA and KRB5-DES-CBC3-SHA since there's already a "!DES" rule.

(cherry picked from commit 4584b63)
@jsvd jsvd merged commit 611bfd4 into 8.4 Sep 7, 2022
@jsvd jsvd deleted the backport_14499_8.4 branch September 7, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant