Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #14507 to 8.4: Manually import CSV gem to work around thread leak #14508

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2022

Backport PR #14507 to 8.4 branch, original message:


The version of CSV included in jruby distributions >= 9.3.0.0 and < 9.3.8.0 include a bug that triggers a thread leak when calling parse_line in CSV files.

This commit updates the version of the CSV gem to the latest version, which includes fixes, and remains compatible with ruby 2.6

Relates: jruby/jruby#7346
Fixes: #14498

* Manually import CSV gem to work around thread leak

The version of CSV included in jruby distributions >= `9.3.0.0` and
< `9.3.8.0` include a bug that triggers a thread leak when calling
`parse_line` in CSV files.

This commit updates the version of the CSV gem to the latest version,
which includes fixes, and remains compatible with ruby 2.6

Relates: jruby/jruby#7346

* Add CSV license info

(cherry picked from commit 8d41b85)
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robbavey robbavey merged commit fae275d into 8.4 Sep 7, 2022
@jsvd jsvd deleted the backport_14507_8.4 branch June 2, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants